Skip to content

Having to manually declare default connection name #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverbackdan opened this issue Dec 18, 2017 · 3 comments
Closed

Having to manually declare default connection name #299

silverbackdan opened this issue Dec 18, 2017 · 3 comments
Milestone

Comments

@silverbackdan
Copy link
Contributor

silverbackdan commented Dec 18, 2017

Hi,

I've found just a small issue with the current master branch.

It seems in the master branch at the moment (which I'm using so it is compatible with SF4) I have to define the connection like this:

doctrine_phpcr:
    session:
        default_session: default
        sessions:
            default:
...

Like this:

doctrine_phpcr:
    session:
...

I get an unknown service error:

 You have requested a non-existent service "doctrine_phpcr.jackalope_doctrine_dbal._connection"

Where 'default' is not detected as the session name and the service should be doctrine_phpcr.jackalope_doctrine_dbal.default_connection

@dbu
Copy link
Member

dbu commented Dec 22, 2017

that sounds wrong indeed. would you mind trying to find whats happening in the DI class and send a pull request to fix it if you find it? not sure how much the class moved around, maybe comparing with how that part of the logic looks in version 1.x would help finding the issue...

@dbu dbu added this to the 2.0 milestone Jan 24, 2018
@dbu
Copy link
Member

dbu commented Feb 24, 2018

i can't seem to reproduce this in symfony-cmf/cmf-sandbox#403 (there is a lot not yet right with that PR, but i did not encounter that problem. we have the short syntax for just one session in the sandbox and it seems to work. can you still reproduce the problem?

@silverbackdan
Copy link
Contributor Author

OK cool, I haven't checked again recently but if it can't be reproduced there then happy for this to be closed and I can always re-open another issue in future if it crops up again for any reason. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants