Skip to content

Setting IncludeSourceRevisionInInformationalVersion may cause RepositoryUrl assembly attribute to be empty #48580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmat opened this issue Apr 18, 2025 · 0 comments · Fixed by #48582
Closed

Setting IncludeSourceRevisionInInformationalVersion may cause RepositoryUrl assembly attribute to be empty #48580

tmat opened this issue Apr 18, 2025 · 0 comments · Fixed by #48582
Labels
Area-NetSDK

Comments

@tmat
Copy link
Member

tmat commented Apr 18, 2025

GetAssemblyAttributes target may execute before InitializeSourceControlInformationFromSourceControlManager,
which results in RepositoryUrl being empty in the generated assembly level attribute:

Image

If design-time build and regular build execute these targets in different order it blocks debugging because Hot Reload will attempt to apply the change to this attribute, which is currently not supported.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Apr 18, 2025
tmat added a commit to tmat/sdk that referenced this issue Apr 18, 2025
@tmat
Fixes RepositoryUrl attribute generation: dotnet#48580
4b335ed
tmat added a commit to tmat/sdk that referenced this issue Apr 18, 2025
@tmat
Fixes RepositoryUrl attribute generation: dotnet#48580
d1ec7be
@tmat tmat mentioned this issue Apr 18, 2025
Merged
@dotnet-policy-service dotnet-policy-service bot removed the untriaged Request triage from a team member label Apr 22, 2025
github-actions bot pushed a commit that referenced this issue Apr 22, 2025
@tmat
Fixes RepositoryUrl attribute generation: #48580
9aca86e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-NetSDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes RepositoryUrl attribute generation tmat/sdk
1 participant
@tmat