Address 9.0-preview feedback (#8497)

Author: flobernd

docs/release-notes/breaking-changes.md

@@ -26,17 +26,17 @@ Breaking changes can impact your Elastic applications, potentially disrupting no
 - [1. Container types](#1-container-types)
 - [2. Removal of certain generic request descriptors](#2-removal-of-certain-generic-request-descriptors)
 - [3. Removal of certain descriptor constructors and related request APIs](#3-removal-of-certain-descriptor-constructors-and-related-request-apis)
-- [4. Date / Time / Duration values](#4-date--time--duration-values)
+- [4. Date / Time / Duration values](#4-date-time-duration-values)
 - [5. `ExtendedBounds`](#5-extendedbounds)
 - [6. `Field.Format`](#6-fieldformat)
 - [7. `Field`/`Fields` semantics](#7-fieldfields-semantics)
 - [8. `FieldValue`](#8-fieldvalue)
 - [9. `FieldSort`](#9-fieldsort)
-- [10. Descriptor types `class` -\> `struct`](#10-descriptor-types-class---struct)
+- [10. Descriptor types `class` -\> `struct`](#10-descriptor-types-class-struct)
 
 ### Breaking changes
 
-#### 1. Container types
+#### 1. Container types [1-container-types]
 
 **Impact**: High.
 
@@ -67,7 +67,20 @@ new SearchRequest
 };
 ```
 
-#### 2. Removal of certain generic request descriptors
+Previously required methods like e.g. `TryGet<TVariant>(out)` have been removed.
+
+The new recommended way of inspecting container types is to use simple pattern matching:
+
+```csharp
+var query = new Query();
+
+if (query.Nested is { } nested)
+{
+    // We have a nested query.
+}
+```
+
+#### 2. Removal of certain generic request descriptors [2-removal-of-certain-generic-request-descriptors]
 
 **Impact**: High.
 
@@ -126,7 +139,7 @@ List of affected descriptors:
 - `TokenizationConfigDescriptor<TDocument>`
 - `UpdateDataFrameAnalyticsRequestDescriptor<TDocument>`
 
-#### 3. Removal of certain descriptor constructors and related request APIs
+#### 3. Removal of certain descriptor constructors and related request APIs [3-removal-of-certain-descriptor-constructors-and-related-request-apis]
 
 **Impact**: High.
 
@@ -159,53 +172,63 @@ new IndexRequestDescriptor(document, "my_index", Id.From(document));
 await client.IndexAsync(document, "my_index", Id.From(document), ...);
 ```
 
-#### 4. Date / Time / Duration values
+#### 4. Date / Time / Duration values [4-date-time-duration-values]
 
 **Impact**: High.
 
 In places where previously `long` or `double` was used to represent a date/time/duration value, `DateTimeOffset` or `TimeSpan` is now used instead.
 
-#### 5. `ExtendedBounds`
+#### 5. `ExtendedBounds` [5-extendedbounds]
 
 **Impact**: High.
 
 Removed `ExtendedBoundsDate`/`ExtendedBoundsDateDescriptor`, `ExtendedBoundsFloat`/`ExtendedBoundsFloatDescriptor`.
 
 Replaced by `ExtendedBounds<T>`, `ExtendedBoundsOfFieldDateMathDescriptor`, and `ExtendedBoundsOfDoubleDescriptor`.
 
-#### 6. `Field.Format`
+#### 6. `Field.Format` [6-fieldformat]
 
 **Impact**: Low.
 
 Removed `Field.Format` property and corresponding constructor and inferrer overloads.
 
 This property has not been used for some time (replaced by the `FieldAndFormat` type).
 
-#### 7. `Field`/`Fields` semantics
+#### 7. `Field`/`Fields` semantics [7-fieldfields-semantics]
 
 **Impact**: Low.
 
 `Field`/`Fields` static factory methods and conversion operators no longer return nullable references but throw exceptions instead (`Field`) if the input `string`/`Expression`/`PropertyInfo` argument is `null`.
 
-This makes implicit conversions to `Field` more user-friendly without requiring the null-forgiveness operator (`!`) ([read more](index.md#field-name-inference)).
+This makes implicit conversions to `Field` more user-friendly without requiring the null-forgiveness operator (`!`) ([read more](index.md#5-field-name-inference)).
 
-#### 8. `FieldValue`
+#### 8. `FieldValue` [8-fieldvalue]
 
 **Impact**: Low.
 
 Removed `FieldValue.IsLazyDocument`, `FieldValue.IsComposite`, and the corresponding members in the `FieldValue.ValueKind` enum.
 
 These values have not been used for some time.
 
-#### 9. `FieldSort`
+#### 9. `FieldSort` [9-fieldsort]
+
+**Impact**: High.
+
+Removed `FieldSort` parameterless constructor.
+
+Please use the new constructor instead:
+
+```csharp
+public FieldSort(Elastic.Clients.Elasticsearch.Field field)
+```
 
 **Impact**: Low.
 
 Removed static `FieldSort.Empty` member.
 
-Sorting got reworked which makes this member obsolete ([read more](index.md#sorting)).
+Sorting got reworked which makes this member obsolete ([read more](index.md#8-sorting)).
 
-#### 10. Descriptor types `class` -> `struct`
+#### 10. Descriptor types `class` -> `struct` [10-descriptor-types-class-struct]
 
 **Impact**: Low.
 

docs/release-notes/index.md

@@ -300,6 +300,19 @@ var agg = new Aggregation
 };
 ```
 
+Previously required methods like e.g. `TryGet<TVariant>(out)` have been removed.
+
+The new recommended way of inspecting container types is to use simple pattern matching:
+
+```csharp
+var query = new Query();
+
+if (query.Nested is { } nested)
+{
+    // We have a nested query.
+}
+```
+
 :::{warning}
 
 A container can still only contain a single variant. Setting multiple variants at once is invalid.

docs/release-notes/known-issues.md

@@ -5,6 +5,8 @@ navigation_title: "Known issues"
 
 # Elasticsearch .NET Client known issues [elasticsearch-net-client-known-issues]
 
+Known issues are significant defects or limitations that may impact your implementation. These issues are actively being worked on and will be addressed in a future release. Review the Elasticsearch .NET Client known issues to help you make informed decisions, such as upgrading to a new version.
+
 % Use the following template to add entries to this page.
 
 % :::{dropdown} Title of known issue
@@ -17,4 +19,6 @@ navigation_title: "Known issues"
 % **Resolved**
 % On [Month/Day/Year], this issue was resolved.
 
-:::
+:::
+
+Known issues are tracked on [GitHub](https://github.com/elastic/elasticsearch-net/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Category%3A%20Bug%22).

src/Elastic.Clients.Elasticsearch/_Generated/Client/ElasticsearchClient.Cluster.g.cs

@@ -388,6 +388,14 @@ public virtual Elastic.Clients.Elasticsearch.Cluster.HealthResponse Health(Elast
 		return DoRequest<Elastic.Clients.Elasticsearch.Cluster.HealthRequest, Elastic.Clients.Elasticsearch.Cluster.HealthResponse, Elastic.Clients.Elasticsearch.Cluster.HealthRequestParameters>(request);
 	}
 
+	public virtual Elastic.Clients.Elasticsearch.Cluster.HealthResponse Health<TDocument>()
+	{
+		var builder = new Elastic.Clients.Elasticsearch.Cluster.HealthRequestDescriptor<TDocument>();
+		var request = builder.Instance;
+		request.BeforeRequest();
+		return DoRequest<Elastic.Clients.Elasticsearch.Cluster.HealthRequest, Elastic.Clients.Elasticsearch.Cluster.HealthResponse, Elastic.Clients.Elasticsearch.Cluster.HealthRequestParameters>(request);
+	}
+
 	public virtual Elastic.Clients.Elasticsearch.Cluster.HealthResponse Health<TDocument>(System.Action<Elastic.Clients.Elasticsearch.Cluster.HealthRequestDescriptor<TDocument>> action)
 	{
 		var builder = new Elastic.Clients.Elasticsearch.Cluster.HealthRequestDescriptor<TDocument>();
@@ -446,6 +454,14 @@ public virtual Elastic.Clients.Elasticsearch.Cluster.HealthResponse Health<TDocu
 		return DoRequestAsync<Elastic.Clients.Elasticsearch.Cluster.HealthRequest, Elastic.Clients.Elasticsearch.Cluster.HealthResponse, Elastic.Clients.Elasticsearch.Cluster.HealthRequestParameters>(request, cancellationToken);
 	}
 
+	public virtual System.Threading.Tasks.Task<Elastic.Clients.Elasticsearch.Cluster.HealthResponse> HealthAsync<TDocument>(System.Threading.CancellationToken cancellationToken = default)
+	{
+		var builder = new Elastic.Clients.Elasticsearch.Cluster.HealthRequestDescriptor<TDocument>();
+		var request = builder.Instance;
+		request.BeforeRequest();
+		return DoRequestAsync<Elastic.Clients.Elasticsearch.Cluster.HealthRequest, Elastic.Clients.Elasticsearch.Cluster.HealthResponse, Elastic.Clients.Elasticsearch.Cluster.HealthRequestParameters>(request, cancellationToken);
+	}
+
 	public virtual System.Threading.Tasks.Task<Elastic.Clients.Elasticsearch.Cluster.HealthResponse> HealthAsync<TDocument>(System.Action<Elastic.Clients.Elasticsearch.Cluster.HealthRequestDescriptor<TDocument>> action, System.Threading.CancellationToken cancellationToken = default)
 	{
 		var builder = new Elastic.Clients.Elasticsearch.Cluster.HealthRequestDescriptor<TDocument>();