Skip to content

Commit 0745b5f

Browse files
Merge pull request #13 from laironacosta/feature/deploy-to-aws-ecs
updating aws yml to deploy on ecs
2 parents 8fe71a0 + bce637f commit 0745b5f

File tree

2 files changed

+21
-9
lines changed

2 files changed

+21
-9
lines changed

.github/workflows/aws.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,13 @@ jobs:
6969
uses: aws-actions/amazon-ecs-render-task-definition@v1
7070
with:
7171
task-definition: task-definition.json
72-
container-name: ms-gin-go-container
72+
container-name: ms-gin-go-app
7373
image: ${{ steps.build-image.outputs.image }}
7474

7575
- name: Deploy Amazon ECS task definition
7676
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
7777
with:
7878
task-definition: ${{ steps.task-def.outputs.task-definition }}
79-
service: ms-gin-go-container-service
80-
cluster: default-dev
79+
service: ms-gin-go-app-service
80+
cluster: dev-cluster
8181
wait-for-service-stability: true

task-definition.json

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"logDriver": "awslogs",
1010
"secretOptions": null,
1111
"options": {
12-
"awslogs-group": "/ecs/ms-gin-go-task-definition",
12+
"awslogs-group": "/ecs/ms-gin-go-app-task-definition",
1313
"awslogs-region": "us-east-2",
1414
"awslogs-stream-prefix": "ecs"
1515
}
@@ -42,7 +42,7 @@
4242
"memoryReservation": 512,
4343
"volumesFrom": [],
4444
"stopTimeout": null,
45-
"image": "alpine:latest",
45+
"image": "027479467189.dkr.ecr.us-east-2.amazonaws.com/dev-repos",
4646
"startTimeout": null,
4747
"firelensConfiguration": null,
4848
"dependsOn": null,
@@ -59,7 +59,7 @@
5959
"dockerLabels": null,
6060
"systemControls": null,
6161
"privileged": null,
62-
"name": "ms-gin-go-container"
62+
"name": "ms-gin-go-app"
6363
}
6464
],
6565
"placementConstraints": [],
@@ -69,8 +69,8 @@
6969
"EC2",
7070
"FARGATE"
7171
],
72-
"taskDefinitionArn": "arn:aws:ecs:us-east-2:027479467189:task-definition/ms-gin-go-task-definition:7",
73-
"family": "ms-gin-go-task-definition",
72+
"taskDefinitionArn": "arn:aws:ecs:us-east-2:027479467189:task-definition/ms-gin-go-app-task-definition:1",
73+
"family": "ms-gin-go-app-task-definition",
7474
"requiresAttributes": [
7575
{
7676
"targetId": null,
@@ -84,6 +84,12 @@
8484
"value": null,
8585
"name": "ecs.capability.execution-role-awslogs"
8686
},
87+
{
88+
"targetId": null,
89+
"targetType": null,
90+
"value": null,
91+
"name": "com.amazonaws.ecs.capability.ecr-auth"
92+
},
8793
{
8894
"targetId": null,
8995
"targetType": null,
@@ -96,6 +102,12 @@
96102
"value": null,
97103
"name": "com.amazonaws.ecs.capability.docker-remote-api.1.21"
98104
},
105+
{
106+
"targetId": null,
107+
"targetType": null,
108+
"value": null,
109+
"name": "ecs.capability.execution-role-ecr-pull"
110+
},
99111
{
100112
"targetId": null,
101113
"targetType": null,
@@ -115,7 +127,7 @@
115127
],
116128
"networkMode": "awsvpc",
117129
"cpu": "256",
118-
"revision": 7,
130+
"revision": 1,
119131
"status": "ACTIVE",
120132
"inferenceAccelerators": null,
121133
"proxyConfiguration": null,

0 commit comments

Comments
 (0)