Skip to content

Commit a9a3954

Browse files
committed
[Refactor] use es-errors, get-proto, has-property-descriptors directly
1 parent efd151b commit a9a3954

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

implementation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var IsDetachedBuffer = require('es-abstract/2024/IsDetachedBuffer');
55
var setFunctionName = require('set-function-name');
66
var isSharedArrayBuffer = require('is-shared-array-buffer');
77

8-
var $TypeError = TypeError;
8+
var $TypeError = require('es-errors/type');
99

1010
module.exports = setFunctionName(function detached() {
1111
var O = this; // step 1

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@
4040
"call-bind": "^1.0.8",
4141
"define-properties": "^1.2.1",
4242
"es-abstract": "^1.23.9",
43+
"es-errors": "^1.3.0",
44+
"get-proto": "^1.0.0",
4345
"gopd": "^1.2.0",
46+
"has-property-descriptors": "^1.0.2",
4447
"is-shared-array-buffer": "^1.0.4",
4548
"set-function-name": "^2.0.2"
4649
},

polyfill.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
var implementation = require('./implementation');
44

5-
var supportsDescriptors = require('define-properties').supportsDescriptors;
5+
var supportsDescriptors = require('has-property-descriptors')();
66
var gOPD = require('gopd');
77

88
module.exports = function getPolyfill() {

shim.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
'use strict';
22

3-
var supportsDescriptors = require('define-properties').supportsDescriptors;
3+
var supportsDescriptors = require('has-property-descriptors')();
44
var gOPD = require('gopd');
55

66
var getPolyfill = require('./polyfill');
77
var defineProperty = Object.defineProperty;
8-
var $TypeError = TypeError;
9-
var $SyntaxError = SyntaxError;
10-
var getProto = Object.getPrototypeOf;
8+
var $TypeError = require('es-errors/type');
9+
var $SyntaxError = require('es-errors/syntax');
10+
var getProto = require('get-proto');
1111

1212
module.exports = function shimDetached() {
1313
if (!supportsDescriptors || !getProto) {

test/shimmed.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
require('../auto');
44

55
var test = require('tape');
6-
var defineProperties = require('define-properties');
76
var callBind = require('call-bind');
7+
var supportsDescriptors = require('has-property-descriptors')();
88

99
var isEnumerable = Object.prototype.propertyIsEnumerable;
1010
var functionsHaveNames = require('functions-have-names')();
@@ -24,7 +24,7 @@ test('shimmed', function (t) {
2424
s2t.end();
2525
});
2626

27-
st.test('enumerability', { skip: !defineProperties.supportsDescriptors }, function (et) {
27+
st.test('enumerability', { skip: !supportsDescriptors }, function (et) {
2828
et.equal(false, isEnumerable.call(ArrayBuffer.prototype, 'detached'), 'ArrayBuffer#detached is not enumerable');
2929
et.end();
3030
});

0 commit comments

Comments
 (0)