Using the connected contract instance to call the method failed

[mosspig323]

I'm trying to call a contract method in my unit test:

const [deployer] = await ethers.getSigners();
const mockProvider = new MockProvider();

const ContractFactory = await ethers.getContractFactory("ContractMock", {
      signer: deployer,
      provider: mockProvider,
    });

const contractInstance = await ContractFactory.deploy();
await contractInstance.deployed();

const [wallet1] = await mockProvider.getWallets()

const response = await contractInstance.connect(wallet1).foo({ gasLimit: 100000 });
const result = await response.wait();

console.log(response)
console.log(result)

and run: hardhat test

then it ran without any error, and I checked the std output and it was all correct.

but the state in Contract has not changed.

Then I tried to throw the revert error in contract method like this:

function foo() public {
  require(false, "Revert anyway");
// ... other codes
}

the test still runs correctly without any revert error.

Until I changed the wallet1 from the Wallet to type Signer;

// ...
const [wallet1] = await ethers.getSigner();
// ...

Then it worked.

I'm not sure if this is a bug in etherjs or waffle, so I post it here.

[zemse]

the test still runs correctly without any revert error.

This sounds like the contracts were not compiled. Though you changed the solidity code, but do not recompile the contracts, your tests would be using the bytecode from old JSON output files.

[mosspig323]

This sounds like the contracts were not compiled. Though you changed the solidity code, but do not recompile the contracts, your tests would be using the bytecode from old JSON output files.

Yes, I also suspected this problem. But if I just change the method visible modifier from external to private, I can get the method is not a function error.

And I am sure that every time I re-run the test, the artifact folder and abi files are deleted and regenerated.

[zemse]

This line is specific to hardhat-ethers const [deployer] = await ethers.getSigners();. This actually creates signers that are available on hardhat network (local testing evm).

While const mockProvider = new MockProvider(); this is specific to waffle. This uses ganache under the hood and the getWallets() return wallets that are available on ganache.

So as far I am understanding, if you use a mix of hardhat network (ethers.getSigners()) and ganache (MockProvider), you will run into issues. If you can retry with just using a single provider, i.e. either use hardhat network or use waffle's ganache, that should solve your problem.

Examples that you can look at:

• Hardhat Network: https://github.com/paulrberg/solidity-template/
• Waffle's Mock Provider: https://github.com/EthWorks/Waffle/tree/master/examples/basic