EIP712 TypedData is expected to be a JSON object, not a string

[mikemcclaran]

EIP 712 specifies that TypedData should be a JSON object.
https://eips.ethereum.org/EIPS/eip-712#specification-of-the-eth_signtypeddata-json-rpc

However, it seems as ethers is providing a string as a result of this code here:
https://github.com/ethers-io/ethers.js/blob/master/packages/providers/src.ts/json-rpc-provider.ts#L273

It seems like the JSON.stringify() should be removed.

Is there a reason for the stringify call that I am not understanding?

[ricmoo]

The JSON.stringify is there because MetaMask did not work without it. Has that changed?

[mikemcclaran]

Hmmm... I will have to try with metamask. I have initially encountered this issue when trying to call _signedTypedData while using ganache. I get a 'cannot sign data; string sent, expected object' so I cannot even generate a signature

[ricmoo]

I would favour working in MM and the other wallets before Ganache (it’s easy enough to get ganache updated), but would love to do what the spec says, as long as it works. :)

[mikemcclaran]

Confirmed, unfortunately MM does expect a string :(