Skip to content

Commit b40157e

Browse files
mateoguzmanafacebook-github-bot
authored andcommitted
Make FabricEventEmitter internal (#51001)
Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.fabric.events.FabricEventEmitter). ## Changelog: [INTERNAL] - Make com.facebook.react.fabric.events.FabricEventEmitter internal Pull Request resolved: #51001 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cortinico, NickGerleman Differential Revision: D73895164 Pulled By: arushikesarwani94 fbshipit-source-id: 46adb077f5d3ee93fe7006c0ffc6c9e87d50147f
1 parent ae2773f commit b40157e

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2397,14 +2397,6 @@ public final class com/facebook/react/fabric/events/EventBeatManager : com/faceb
23972397
public fun onBatchEventDispatched ()V
23982398
}
23992399

2400-
public final class com/facebook/react/fabric/events/FabricEventEmitter : com/facebook/react/uimanager/events/RCTModernEventEmitter {
2401-
public fun <init> (Lcom/facebook/react/fabric/FabricUIManager;)V
2402-
public fun receiveEvent (IILjava/lang/String;Lcom/facebook/react/bridge/WritableMap;)V
2403-
public fun receiveEvent (IILjava/lang/String;ZILcom/facebook/react/bridge/WritableMap;I)V
2404-
public fun receiveEvent (ILjava/lang/String;Lcom/facebook/react/bridge/WritableMap;)V
2405-
public fun receiveTouches (Ljava/lang/String;Lcom/facebook/react/bridge/WritableArray;Lcom/facebook/react/bridge/WritableArray;)V
2406-
}
2407-
24082400
public class com/facebook/react/fabric/mounting/MountItemDispatcher {
24092401
public fun <init> (Lcom/facebook/react/fabric/mounting/MountingManager;Lcom/facebook/react/fabric/mounting/MountItemDispatcher$ItemDispatchListener;)V
24102402
public fun addMountItem (Lcom/facebook/react/fabric/mounting/mountitems/MountItem;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/events/FabricEventEmitter.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ import com.facebook.react.uimanager.events.EventCategoryDef
1515
import com.facebook.react.uimanager.events.RCTModernEventEmitter
1616
import com.facebook.systrace.Systrace
1717

18-
public class FabricEventEmitter(private val uiManager: FabricUIManager) : RCTModernEventEmitter {
18+
internal class FabricEventEmitter(private val uiManager: FabricUIManager) : RCTModernEventEmitter {
1919
@Deprecated("Deprecated in Java")
20-
public override fun receiveEvent(targetTag: Int, eventName: String, params: WritableMap?): Unit {
20+
override fun receiveEvent(targetTag: Int, eventName: String, params: WritableMap?): Unit {
2121
receiveEvent(ViewUtil.NO_SURFACE_ID, targetTag, eventName, params)
2222
}
2323

24-
public override fun receiveEvent(
24+
override fun receiveEvent(
2525
surfaceId: Int,
2626
targetTag: Int,
2727
eventName: String,
@@ -30,7 +30,7 @@ public class FabricEventEmitter(private val uiManager: FabricUIManager) : RCTMod
3030
receiveEvent(surfaceId, targetTag, eventName, false, 0, params, EventCategoryDef.UNSPECIFIED)
3131
}
3232

33-
public override fun receiveEvent(
33+
override fun receiveEvent(
3434
surfaceId: Int,
3535
targetTag: Int,
3636
eventName: String,
@@ -49,7 +49,7 @@ public class FabricEventEmitter(private val uiManager: FabricUIManager) : RCTMod
4949

5050
/** Touches are dispatched by [.receiveTouches] */
5151
@Deprecated("Deprecated in Java")
52-
public override fun receiveTouches(
52+
override fun receiveTouches(
5353
eventName: String,
5454
touches: WritableArray,
5555
changedIndices: WritableArray

0 commit comments

Comments
 (0)