[BUG] Problem with uploading logo from theme folder to hyde on arch

[eigver]

Read the FAQ first

• I have checked the FAQ but the issue is not covered

Description

I wanted to have different logos in different themes, in fastfetch.sh there are these lines
if [ -n “${HYDE_THEME}” ] && [ -d “${confDir}/hyde/themes/${HYDE_THEME}/logo” ]; then
image_dirs+=(“${confDir}/hyde/themes/${HYDE_THEME}/logo/”)
fi
So I added the logo directory to one of the themes and put my image there. After that instead of the expected picture I got ascii arch logo.

At the same time when writing the path manually in ~/.config/fastfetch/config.jsonc
“source” : ‘$HOME/path/to/your/ultmate/logo/best.png’, the logo is displayed correctly.
Also I know that fastfetch.sh logo outputs the correct path, also when simulated in terminal everything works, thanks for this information khing.

The logo itself is fine and when moved to the ~/.config/fastfetch/logo folder it displays correctly

fastfetch.sh logo --theme
/home/eigver/.config/hyde/themes/Rosé Pine/logo/roxy_icon.png
fastfetch --show-errors
Logo: Image source "$(fastfetch.sh logo --theme)" does not exist
I don't know if it's useful, but let it be.

I did this and still get the same error again
fastfetch --show-errors
Logo: Image source “$(bash /home/eigver/.local/lib/hyde/test.sh)” does not exist, I can assure you that the script itself is written correctly and the path is also correct.

bash /home/eigver/.local/lib/hyde/test.sh
/home/eigver/.config/hyde/themes/Rosé Pine/logo/roxy_icon.png

ls “/home/eigver/.config/hyde/themes/Rosé Pine/logo/roxy_icon.png”.
'/home/eigver/.config/hyde/themes/Rosé Pine/logo/roxy_icon.png'

here's what's inside /home/eigver/.local/lib/hyde/test.sh
echo “/home/eigver/.config/hyde/themes/Rosé Pine/logo/roxy_icon.png”.

and here's what's inside the config ~/.config/fastfetch/config.jsonc
“logo": {

“source“:”$(bash /home/eigver/.local/lib/hyde/test.sh)”,

“height”: 18
},

I moved graphite mono to the theme and it turns out the same thing, I think it's worth trying to create a theme without spaces. (but I think that's not the mistake).
I I forgot to write yesterday
fastfetch —logo command is "$(bash /home/eigver/.local/lib/hyde/test.sh)"
it works correctly, and the logo appears.

HyDE-Project/HyDE#507

Version used

fastfetch 2.40.4 (x86_64)

Bug prevalence

Always

Regression

Not sure

Installation

Package manager

Package manager

pacman

Screenshots

config.jsonc

Configuration

Attached the entire file above, as it is not very convenient with “cat” for personal reasons

Image protocol

.png

Terminal

zsh on kitty

Image tried

https://bafybeiamvcvk7sr7mscdu73jaqhwghjo7d6x3msgt3qzr7fsojfvqoc37e.ipfs.dweb.link?filename=roxy_icon.png

Error message

fastfetch --show-errors
Logo: Image source "$(fastfetch.sh logo)" does not exist

Features built-in

threads                                                                                                                 vulkan                                                                                                                  wayland                                                                                                                 xcb-randr                                                                                                               xrandr                                                                                                                  drm                                                                                                                     drm_amdgpu                                                                                                              gio                                                                                                                     dconf                                                                                                                   dbus                                                                                                                    imagemagick7                                                                                                            chafa                                                                                                                   zlib                                                                                                                    xfconf                                                                                                                  opencl                                                                                                                  libpulse                                                                                                                libddcutil                                                                                                              libelf                                                                                                                  libzfs                                                                                                                  Directx Headers                                                                                                         System yyjson                                                                                                           linux/videodev2  
linux/wireless

[CarterLi]

Reformatted by AI

---

Description

I wanted to have different logos in different themes. In fastfetch.sh, there are the following lines:

if [ -n “${HYDE_THEME}” ] && [ -d “${confDir}/hyde/themes/${HYDE_THEME}/logo” ]; then
    image_dirs+=(“${confDir}/hyde/themes/${HYDE_THEME}/logo/”)
fi

I added the logo directory to one of the themes and placed my image there. However, instead of the expected picture, I got the ASCII Arch logo.

• When I manually set the path in ~/.config/fastfetch/config.jsonc:

  "source": "$HOME/path/to/your/ultimate/logo/best.png"

  The logo displays correctly.

• The fastfetch.sh logo command outputs the correct path, and when simulated in the terminal, everything works as expected. For example:

  fastfetch.sh logo --theme
  /home/eigver/.config/hyde/themes/Rosé Pine/logo/roxy_icon.png

• However, running fastfetch --show-errors gives the following error:

  Logo: Image source "$(fastfetch.sh logo --theme)" does not exist
  

• I also tried:

  fastfetch --show-errors
  Logo: Image source "$(bash /home/eigver/.local/lib/hyde/test.sh)" does not exist

  Despite the script and path being correct.

Additional Observations

• The logo works fine if moved to the ~/.config/fastfetch/logo folder.
• Using themes with spaces in their names (e.g., Rosé Pine) might be causing issues, though this is unconfirmed.
• Directly specifying the logo path in ~/.config/fastfetch/config.jsonc works correctly.

Configuration

• ~/.config/fastfetch/config.jsonc:

  {
    "logo": {
      "source": "$(bash /home/eigver/.local/lib/hyde/test.sh)",
      "height": 18
    }
  }

• Script (/home/eigver/.local/lib/hyde/test.sh):

  echo "/home/eigver/.config/hyde/themes/Rosé Pine/logo/roxy_icon.png"

Steps to Reproduce

1. Add a logo directory to a theme.
2. Place an image (e.g., roxy_icon.png) in the theme's logo directory.
3. Update ~/.config/fastfetch/config.jsonc to use the script that echoes the path to the logo:

   {
     "logo": {
       "source": "$(bash /path/to/script.sh)",
       "height": 18
     }
   }

4. Run fastfetch --show-errors and observe the error.

Version Used

• fastfetch version: 2.40.4 (x86_64)
• Package manager: pacman

Terminal

• zsh on Kitty

Error Messages

• fastfetch --show-errors:

  Logo: Image source "$(fastfetch.sh logo)" does not exist
  

Attached Files and Images

• config.jsonc
• 
• 

Features Built-in

threads
vulkan
wayland
xcb-randr
xrandr
drm
drm_amdgpu
gio
dconf
dbus
imagemagick7
chafa
zlib
xfconf
opencl
libpulse
libddcutil
libelf
libzfs
Directx Headers
System yyjson
linux/videodev2
linux/wireless

[kRHYME7]

Hi! I am a maintainer of the dotfiles which is being referenced here. I would like to clear things out to avoid confusion.

So, the main gist is, the "source" key in config.jsonc fails when the output path (generated by a script outputs a path with spaces in it.

• Output path with no space works for both cli and jsonc.

• Output path with spaces works on cli but fails on jsonc.

• Hard coded path either with/out spaces works for both cli and jsonc.

and also @eigver reports that it works in neofetch.

---

The only one failing is when a script outputs a path with spaces.

[CarterLi]

Because the file path contains white space, it must be quoted: "source": "\"$(bash /path/to/script.sh)\""

To test the source path, in sh:

$ ls -l "$(~/script.sh)" # ls -l <text-in-logo-source>

[CarterLi]

and also @eigver reports that it works in neofetch.

This doesn't help. Neofetch itself is written in bash, so it works better with bash scripts of course. fastfetch is not neofetch.

[kRHYME7]

Because the file path contains white space, it must be quoted: "source": "\"$(bash /path/to/script.sh)\""

To test the source path, in sh:

$ ls -l "$(~/script.sh)" # ls -l

I tried quoting it as an output lol. It made sence now as the quote in jsonc are not included.

Thank you!