[CQ] stop blocking on FlutterPluginsLibraryManager update (#8094)

See: #8089

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md

Author: pq

flutter-idea/src/io/flutter/pub/PubRoots.java

@@ -48,7 +48,7 @@ public static List<PubRoot> forModule(@NotNull Module module) {
    * (Based on the filesystem cache; doesn't refresh anything.)
    */
   @NotNull
-  public static List<PubRoot> forProject(@NotNull Project project) {
+  public static List<@NotNull PubRoot> forProject(@NotNull Project project) {
     final List<PubRoot> result = new ArrayList<>();
     if (project.isDisposed()) return result;
 

flutter-idea/src/io/flutter/sdk/FlutterPluginsLibraryManager.java

@@ -7,13 +7,16 @@
 
 import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.application.ModalityState;
+import com.intellij.openapi.application.ReadAction;
 import com.intellij.openapi.project.DumbService;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.roots.ModuleRootEvent;
 import com.intellij.openapi.roots.ModuleRootListener;
 import com.intellij.openapi.roots.libraries.PersistentLibraryKind;
 import com.intellij.openapi.vfs.*;
+import com.intellij.util.concurrency.AppExecutorUtil;
 import com.jetbrains.lang.dart.util.DotPackagesFileUtil;
+import io.flutter.dart.FlutterDartAnalysisServer;
 import io.flutter.pub.PubRoot;
 import io.flutter.pub.PubRoots;
 import org.jetbrains.annotations.NotNull;
@@ -97,7 +100,7 @@ private void scheduleUpdate() {
     }
 
     final Runnable runnable = this::updateFlutterPlugins;
-    DumbService.getInstance(getProject()).smartInvokeLater(runnable, ModalityState.NON_MODAL);
+    DumbService.getInstance(getProject()).smartInvokeLater(runnable, ModalityState.nonModal());
   }
 
   private void updateFlutterPlugins() {
@@ -114,15 +117,22 @@ private void updateFlutterPlugins() {
   }
 
   private void updateFlutterPluginsImpl() {
-    final Set<String> flutterPluginPaths = getFlutterPluginPaths(PubRoots.forProject(getProject()));
-    final Set<String> flutterPluginUrls = new HashSet<>();
-    for (String path : flutterPluginPaths) {
-      flutterPluginUrls.add(VfsUtilCore.pathToUrl(path));
-    }
-    updateLibraryContent(flutterPluginUrls);
+    Project project = getProject();
+
+    ReadAction.nonBlocking(() -> getFlutterPluginPaths(PubRoots.forProject(project)))
+      .expireWith(FlutterDartAnalysisServer.getInstance(project))
+      .finishOnUiThread(ModalityState.nonModal(), flutterPluginPaths -> {
+        if (flutterPluginPaths == null) return;
+        final Set<String> flutterPluginUrls = new HashSet<>();
+        for (String path : flutterPluginPaths) {
+          flutterPluginUrls.add(VfsUtilCore.pathToUrl(path));
+        }
+        updateLibraryContent(flutterPluginUrls);
+      })
+      .submit(AppExecutorUtil.getAppExecutorService());
   }
 
-  private static Set<String> getFlutterPluginPaths(List<PubRoot> roots) {
+  private static @NotNull Set<@NotNull String> getFlutterPluginPaths(@NotNull List<@NotNull PubRoot> roots) {
     final Set<String> paths = new HashSet<>();
 
     for (PubRoot pubRoot : roots) {
@@ -132,6 +142,7 @@ private static Set<String> getFlutterPluginPaths(List<PubRoot> roots) {
       }
 
       for (String packagePath : packagesMap.values()) {
+        if (packagePath == null) continue;;
         final VirtualFile libFolder = LocalFileSystem.getInstance().findFileByPath(packagePath);
         if (libFolder == null) {
           continue;