Skip to content
This repository was archived by the owner on Oct 28, 2020. It is now read-only.

Commit e572b5c

Browse files
author
v.promzelev
committed
use appraisals for testing with different versions of activerecord
1 parent 676e454 commit e572b5c

File tree

7 files changed

+37
-5
lines changed

7 files changed

+37
-5
lines changed

Appraisals

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
appraise 'ar50' do
2+
gem 'activerecord', '~> 5.0'
3+
end
4+
5+
appraise 'ar42' do
6+
gem 'activerecord', '~> 4.2'
7+
end
8+
9+
appraise 'ar32' do
10+
gem 'activerecord', '~> 3.2'
11+
end

Gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,3 @@ source 'https://rubygems.org'
22

33
# Specify your gem's dependencies in activerecord-overflow_signalizer.gemspec
44
gemspec
5-
6-
gem 'byebug'
7-
gem 'pry'

activerecord-overflow_signalizer.gemspec

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,13 @@ Gem::Specification.new do |spec|
3030
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
3131
spec.require_paths = ['lib']
3232

33-
spec.add_runtime_dependency 'activerecord', '~> 3.2'
33+
# spec.add_runtime_dependency 'activerecord', '~> 3.2'
3434
spec.add_runtime_dependency 'pg'
3535

3636
spec.add_development_dependency 'bundler', '~> 1.14'
3737
spec.add_development_dependency 'rake', '~> 10.0'
3838
spec.add_development_dependency 'rspec', '~> 3.0'
39+
spec.add_development_dependency 'appraisal', '~> 2.0'
40+
spec.add_development_dependency 'byebug'
41+
spec.add_development_dependency 'pry'
3942
end

gemfiles/ar32.gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# This file was generated by Appraisal
2+
3+
source "https://rubygems.org"
4+
5+
gem "activerecord", "~> 3.2"
6+
7+
gemspec :path => "../"

gemfiles/ar42.gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# This file was generated by Appraisal
2+
3+
source "https://rubygems.org"
4+
5+
gem "activerecord", "~> 4.2"
6+
7+
gemspec :path => "../"

gemfiles/ar50.gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# This file was generated by Appraisal
2+
3+
source "https://rubygems.org"
4+
5+
gem "activerecord", "~> 5.0"
6+
7+
gemspec :path => "../"

lib/activerecord/overflow_signalizer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def initialize(logger: nil, models: nil, days_count: 60)
2222
def analyse!
2323
@models.group_by(&:table_name).each do |table, models|
2424
model = models.first
25-
pk = model.columns.select(&:primary).first
25+
pk = model.columns.select { |c| c.name == model.primary_key }.first
2626
next if model.last.nil?
2727
if (max_value(pk.sql_type) - model.last.id) / avg(model) <= @days_count
2828
signalize(table, model.last.public_send(pk.name), max_value(pk.sql_type))

0 commit comments

Comments
 (0)