Skip to content

Commit 9df73ea

Browse files
committed
Align tests
1 parent f9fced8 commit 9df73ea

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

dev-packages/e2e-tests/test-applications/remix-hydrogen/tests/server-transactions.test.ts

-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ test('Sends two linked transactions (server & client) to Sentry', async ({ page
4040

4141
const httpServerTraceId = httpServerTransaction.contexts?.trace?.trace_id;
4242
const httpServerSpanId = httpServerTransaction.contexts?.trace?.span_id;
43-
const loaderSpanId = httpServerTransaction?.spans?.find(span => span.op === 'function.remix.loader')?.span_id;
4443

4544
const pageLoadTraceId = pageloadTransaction.contexts?.trace?.trace_id;
4645
const pageLoadSpanId = pageloadTransaction.contexts?.trace?.span_id;
@@ -50,7 +49,6 @@ test('Sends two linked transactions (server & client) to Sentry', async ({ page
5049

5150
expect(httpServerTraceId).toBeDefined();
5251
expect(httpServerSpanId).toBeDefined();
53-
expect(loaderSpanId).toBeDefined();
5452

5553
expect(pageLoadTraceId).toEqual(httpServerTraceId);
5654
expect(pageLoadSpanId).not.toEqual(httpServerSpanId);

packages/remix/test/integration/test/server/instrumentation/action.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@ describe('Remix API Actions', () => {
2828
data: {
2929
'code.function': 'loader',
3030
'sentry.op': 'loader.remix',
31-
'match.route.id': 'routes/action-json-response.$id',
31+
'match.route.id': 'root',
3232
'match.params.id': '123123',
3333
},
3434
},
3535
{
3636
data: {
3737
'code.function': 'loader',
3838
'sentry.op': 'loader.remix',
39-
'match.route.id': 'root',
39+
'match.route.id': 'routes/action-json-response.$id',
4040
'match.params.id': '123123',
4141
},
4242
},

packages/remix/test/integration/test/server/instrumentation/loader.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -242,14 +242,14 @@ describe('Remix API Loaders', () => {
242242
data: {
243243
'code.function': 'loader',
244244
'sentry.op': 'loader.remix',
245-
'match.route.id': 'routes/loader-defer-response.$id',
245+
'match.route.id': 'root',
246246
},
247247
},
248248
{
249249
data: {
250250
'code.function': 'loader',
251251
'sentry.op': 'loader.remix',
252-
'match.route.id': 'root',
252+
'match.route.id': 'routes/loader-defer-response.$id',
253253
},
254254
},
255255
],

0 commit comments

Comments
 (0)