feat(issue-views): Allow org owners/managers to edit/delete issue views (#90112)

Author: malwilley

static/app/views/issueList/issueViews/issueViewSaveButton.spec.tsx

@@ -1,5 +1,6 @@
 import {Fragment} from 'react';
 import {GroupSearchViewFixture} from 'sentry-fixture/groupSearchView';
+import {OrganizationFixture} from 'sentry-fixture/organization';
 import {UserFixture} from 'sentry-fixture/user';
 
 import {
@@ -231,6 +232,9 @@ describe('IssueViewSaveButton', function () {
         <GlobalModal />
       </Fragment>,
       {
+        organization: OrganizationFixture({
+          access: ['org:read'],
+        }),
         enableRouterMocks: false,
         initialRouterConfig: initialRouterConfigView,
       }

static/app/views/issueList/issueViews/issueViewSaveButton.tsx

@@ -42,7 +42,9 @@ function SegmentedIssueViewSaveButton({
   const {data: view} = useSelectedGroupSearchView();
   const {mutate: updateGroupSearchView, isPending: isSaving} = useUpdateGroupSearchView();
   const user = useUser();
-  const canEdit = view ? canEditIssueView({user, groupSearchView: view}) : false;
+  const canEdit = view
+    ? canEditIssueView({user, groupSearchView: view, organization})
+    : false;
 
   const discardUnsavedChanges = () => {
     if (view) {

static/app/views/issueList/issueViews/issueViewsList/issueViewsTable.tsx

@@ -71,7 +71,7 @@ export function IssueViewsTable({
       emptyMessage={t('No saved views found')}
     >
       {views.map((view, index) => {
-        const canEdit = canEditIssueView({groupSearchView: view, user});
+        const canEdit = canEditIssueView({groupSearchView: view, user, organization});
 
         return (
           <SavedEntityTable.Row

static/app/views/issueList/issueViews/utils.tsx

@@ -1,5 +1,6 @@
 import {openConfirmModal} from 'sentry/components/confirm';
 import {t} from 'sentry/locale';
+import type {Organization} from 'sentry/types/organization';
 import type {User} from 'sentry/types/user';
 import type {GroupSearchView} from 'sentry/views/issueList/types';
 
@@ -15,12 +16,17 @@ export function isNewViewPage(pathname: string) {
 
 export function canEditIssueView({
   groupSearchView,
+  organization,
   user,
 }: {
   groupSearchView: GroupSearchView;
+  organization: Organization;
   user: User;
 }) {
-  // TODO: Allow org admins to edit issue views
+  if (organization.access.includes('org:write')) {
+    return true;
+  }
+
   return user.id === groupSearchView.createdBy.id;
 }
 

static/app/views/issueList/leftNavViewsHeader.spec.tsx

@@ -30,6 +30,7 @@ describe('LeftNavViewsHeader', function () {
   };
 
   const organization = OrganizationFixture({
+    access: ['org:read'],
     features: ['issue-view-sharing'],
   });
 

static/app/views/issueList/leftNavViewsHeader.tsx

@@ -41,7 +41,7 @@ function PageTitle() {
   if (
     hasIssueViewSharing &&
     groupSearchView &&
-    canEditIssueView({groupSearchView, user})
+    canEditIssueView({groupSearchView, user, organization})
   ) {
     return <EditableIssueViewHeader view={groupSearchView} />;
   }
@@ -126,7 +126,7 @@ function IssueViewEditMenu() {
     return null;
   }
 
-  const canDeleteView = canEditIssueView({groupSearchView, user});
+  const canDeleteView = canEditIssueView({groupSearchView, organization, user});
 
   return (
     <DropdownMenu