Skip to content

Commit 55dd11c

Browse files
committed
Just use a property for the release notes file.
1 parent a4eba88 commit 55dd11c

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

GitTfsTasks/CreateRelease.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class CreateRelease : Task
4040

4141
public ITaskItem[] Files { get; set; }
4242

43-
public ITaskItem ReleaseNotesFile { get; set; }
43+
public string ReleaseNotesFile { get; set; }
4444

4545
[Output]
4646
public ITaskItem[] UploadedAssets { get; private set; }
@@ -90,7 +90,7 @@ private ReleaseUpdate BuildReleaseData()
9090
var release = new ReleaseUpdate(TagName);
9191
if (ReleaseNotesFile != null)
9292
{
93-
release.Description = File.ReadAllText(ReleaseNotesFile.ItemSpec);
93+
release.Description = File.ReadAllText(ReleaseNotesFile);
9494
}
9595
return release;
9696
}

release.proj

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,8 @@
9494
</Target>
9595

9696
<!-- Internal: Called by Release to create the release on github.com. -->
97-
<ItemGroup>
98-
<ReleaseNotes Condition="'$(ReleaseNotes)' != ''" Include="$(ReleaseNotes)" />
99-
</ItemGroup>
10097
<Target Name="UploadToGitHub" DependsOnTargets="VersionRequired; AuthTokenRequired; GitTfsTasks">
101-
<CreateRelease Repository="git-tfs/msbuild-tasks" OauthToken="$(GitHubAuthToken)" TagName="$(VersionTag)" Files="@(ArchiveFile)" ReleaseNotesFile="@(ReleaseNotes)">
98+
<CreateRelease Repository="git-tfs/msbuild-tasks" OauthToken="$(GitHubAuthToken)" TagName="$(VersionTag)" Files="@(ArchiveFile)" ReleaseNotesFile="$(ReleaseNotes)">
10299
<Output TaskParameter="UploadedAssets" ItemName="UploadedAssets" />
103100
</CreateRelease>
104101
<Message Text="yes! -> @(UploadedAssets)" />

0 commit comments

Comments
 (0)