Merge pull request #35 from github/aria

Remove aria-haspopup=dialog and add role=button

Author: muan

index.js

@@ -196,7 +196,7 @@ class DetailsDialogElement extends HTMLElement {
 
     const summary = details.querySelector('summary')
     if (summary) {
-      summary.setAttribute('aria-haspopup', 'dialog')
+      summary.setAttribute('role', 'button')
       summary.addEventListener('click', onSummaryClick, {capture: true})
     }
 

test/test.js

@@ -45,6 +45,12 @@ describe('details-dialog-element', function() {
       document.body.innerHTML = ''
     })
 
+    it('initializes', function() {
+      assert.equal(summary.getAttribute('role'), 'button')
+      assert.equal(dialog.getAttribute('role'), 'dialog')
+      assert.equal(dialog.getAttribute('aria-modal'), 'true')
+    })
+
     it('toggles open', function() {
       assert(!details.open)
       dialog.toggle(true)