Skip to content
This repository was archived by the owner on Sep 22, 2022. It is now read-only.

Commit 7522db2

Browse files
authored
Merge pull request #32 from github/open-focus
Fix autofocusing when details is not open & preload toggling
2 parents 0c93a12 + 9b788b2 commit 7522db2

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

index.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ function loadIncludeFragment(event: Event) {
138138
if (src === null) return
139139

140140
loader.addEventListener('loadend', () => {
141-
autofocus(dialog)
141+
if (details.hasAttribute('open')) autofocus(dialog)
142142
})
143143
loader.setAttribute('src', src)
144144
}
@@ -236,12 +236,13 @@ class DetailsDialogElement extends HTMLElement {
236236

237237
if (this.src) {
238238
details.addEventListener('toggle', loadIncludeFragment, {once: true})
239-
240-
if (this.preload) {
241-
details.addEventListener('mouseover', loadIncludeFragment, {once: true})
242-
}
243239
} else {
244240
details.removeEventListener('toggle', loadIncludeFragment)
241+
}
242+
243+
if (this.src && this.preload) {
244+
details.addEventListener('mouseover', loadIncludeFragment, {once: true})
245+
} else {
245246
details.removeEventListener('mouseover', loadIncludeFragment)
246247
}
247248
}

0 commit comments

Comments
 (0)