Skip to content

Safe check Schema for Graphene v3 #52

Closed
@KingDarBoja

Description

@KingDarBoja

While testing locally the new server-core, I noticed I had to do this on my schema:

graphql-server-flask

Notice the graphql_schema part, I don't remember having to use it but since we assert on run_http_query function that it MUST be a GraphQLSchema, now we are forced to use the attribute graphql_schema of the Schema type.

@jkimbo suggested at the Slack channel to add a little compatibility layer to ensure it will work for both cases:

if not a graphql-core schema class then check if the object has an attribute called graphql_schema and use that instead.

This issue was made as remainder.

Metadata

Metadata

Assignees

Labels

type: maintenanceAn issue or pull request describing a change that isn't a bug, feature or documentation change

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions