-
Notifications
You must be signed in to change notification settings - Fork 1k
Add sub_path_expr to volume mount options #2622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jk-f5
wants to merge
1
commit into
hashicorp:main
Choose a base branch
from
jk-f5:feat/sub_path_expr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40da2bc
to
427d5ca
Compare
427d5ca
to
cfeb53a
Compare
Can anyone tell me what I need to do to get this merged? I'd prefer not to have to continue using my own custom build of this provider if possible. |
This was referenced Dec 11, 2024
cfeb53a
to
d90f8f8
Compare
Rebased on main |
d90f8f8
to
15982da
Compare
Rebased on main |
15982da
to
b013271
Compare
Rebased on main |
s-annamalai-fetch
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could get this merged
b013271
to
c5ab516
Compare
Rebased on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ability to declare sub_path_expr in volume mounts. I more or less just grepped for sub_path and added the equivalent code for sub_path_expr. I'm a bit shocked that this hasn't been added already.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note