Skip to content

Commit cfedb56

Browse files
committed
Remove streams
1 parent b46977a commit cfedb56

8 files changed

+0
-172
lines changed

package.json

-2
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,8 @@
3535
"homepage": "https://github.com/jbmusso/gremlin-javascript",
3636
"dependencies": {
3737
"gremlin-template-string": "^2.0.0",
38-
"highland": "^2.5.1",
3938
"lodash": "^3.10.1",
4039
"node-uuid": "^1.4.3",
41-
"readable-stream": "^2.0.2",
4240
"rx": "^4.1.0",
4341
"ws": "^2.3.1"
4442
},

src/GremlinClient.js

-5
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@ import { EventEmitter } from 'events';
44

55
import uuid from 'node-uuid';
66
import _ from 'lodash';
7-
import highland from 'highland';
87

98
import WebSocketGremlinConnection from './WebSocketGremlinConnection';
10-
import MessageStream from './MessageStream';
119
import * as Utils from './utils';
1210

1311
import Rx from 'rx';
@@ -216,9 +214,6 @@ class GremlinClient extends EventEmitter {
216214
* Asynchronously send a script to Gremlin Server for execution and fire
217215
* the provided callback when all results have been fetched.
218216
*
219-
* This method internally uses a stream to handle the potential concatenation
220-
* of results.
221-
*
222217
* Callback signature: (Error, Array<result>)
223218
*
224219
* @public

src/MessageStream.js

-14
This file was deleted.

src/executeHandler.js

-30
This file was deleted.

test/bindings.js

-13
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,6 @@ describe('Bindings', function() {
1313
});
1414
});
1515

16-
it.skip('should support bindings with client.stream()', function(done) {
17-
var client = gremlin.createClient();
18-
var stream = client.stream('g.V(x)', { x: 1 });
19-
20-
stream.on('data', function(result) {
21-
result.id.should.equal(1);
22-
});
23-
24-
stream.on('end', function() {
25-
done();
26-
});
27-
});
28-
2916
it.skip('should give an error with reserved binding name in .exec', function(done) {
3017
var client = gremlin.createClient();
3118

test/createClient.js

-18
Original file line numberDiff line numberDiff line change
@@ -56,24 +56,6 @@ describe('.createClient()', function() {
5656
client.options.aliases.should.eql({ h: 'g' });
5757
});
5858

59-
it.skip('should override a set `processor` option on a per request basis', function(done) {
60-
var client = gremlin.createClient({ op: 'foo' });
61-
62-
client.port.should.equal(8182);
63-
client.host.should.equal('localhost');
64-
client.options.op.should.equal('foo');
65-
66-
var s = client.stream('g.V(1)', null, { op: 'eval' });
67-
68-
s.on('data', function(result) {
69-
result.should.be.an('object');
70-
});
71-
72-
s.on('end', function() {
73-
done();
74-
});
75-
});
76-
7759
describe('WebSocket path', () => {
7860
it('should support a custom websocket path', () => {
7961
const client = gremlin.createClient({ path: '/foo/bar' });

test/messageStream.js

-19
This file was deleted.

test/stream.js

-71
This file was deleted.

0 commit comments

Comments
 (0)