Skip to content

Implement "suggestions, problems, feedback" GitHub footer #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajpiano opened this issue Oct 11, 2012 · 7 comments
Closed

Implement "suggestions, problems, feedback" GitHub footer #43

ajpiano opened this issue Oct 11, 2012 · 7 comments
Assignees

Comments

@ajpiano
Copy link
Member

ajpiano commented Oct 11, 2012

Each article's footer should include a link to the same article in the learn.jquery.com master on GitHub. Though the link obviously won't work for new articles in development, it will be just fine in production on learn.jquery.com, which is where it counts here.

@ajpiano
Copy link
Member Author

ajpiano commented Oct 11, 2012

This was working in nanoc using the article's slug, etc, and we should be able to something similar in the WordPress theme

@johnkpaul
Copy link

Working on this right now.

@johnkpaul
Copy link

Pull request made on web-base-template jquery/jquery-wp-content#72

@jzaefferer
Copy link
Member

I want to have that for pretty much every site we have. So far jQuery UI and QUnit have live sites using web-base-template. Can we generalize the solution above to those, and beyond?

@johnkpaul
Copy link

@jzaefferer It is already generalized. If you take a look at the code, it will work from any theme, not just learn.jquery.com.

@ghost ghost assigned johnkpaul Oct 15, 2012
@johnkpaul
Copy link

This issue will be fixed when this PR is merged in web-base-template jquery/jquery-wp-content#72

@RedWolves
Copy link
Member

Landed - Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants