Skip to content

Commit ab0c544

Browse files
author
Alan Fleming
committed
Manager, WidgetManager and plugin refactoring (simplification) . Warning: some signature changes.
1 parent a7a6d5f commit ab0c544

File tree

6 files changed

+184
-281
lines changed

6 files changed

+184
-281
lines changed

packages/base-manager/src/manager-base.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ export abstract class ManagerBase implements IWidgetManager {
217217
async get_model(model_id: string): Promise<WidgetModel> {
218218
let i = 0;
219219
while (!this._models[model_id] && i < this._sleepTimes.length) {
220-
new Promise((r) => setTimeout(r, this._sleepTimes[i++]))
220+
new Promise((resolve) => setTimeout(resolve, this._sleepTimes[i++]));
221221
}
222222
const modelPromise = this._models[model_id];
223223
if (modelPromise === undefined) {

python/jupyterlab_widgets/package.json

-2
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
"@jupyterlab/services": "^6.0.0 || ^7.0.0",
6565
"@jupyterlab/settingregistry": "^3.0.0 || ^4.0.0",
6666
"@jupyterlab/translation": "^3.0.0 || ^4.0.0",
67-
"@lumino/algorithm": "^1.11.1 || ^2.0.0",
6867
"@lumino/coreutils": "^1.11.1 || ^2.1",
6968
"@lumino/disposable": "^1.10.1 || ^2.1",
7069
"@lumino/properties": "^2.0.1",
@@ -76,7 +75,6 @@
7675
},
7776
"devDependencies": {
7877
"@jupyterlab/builder": "^3.0.0 || ^4.0.0",
79-
"@jupyterlab/cells": "^3.0.0 || ^4.0.0",
8078
"@types/jquery": "^3.5.16",
8179
"@types/semver": "^7.3.6",
8280
"@typescript-eslint/eslint-plugin": "^5.8.0",

0 commit comments

Comments
 (0)