Skip to content

Commit 6a9488f

Browse files
authored
Fix CI by removing <a> and <button> nesting as well as ignoring some working links (#789)
1 parent a19298a commit 6a9488f

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

.github/workflows/validate.yml

+2
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ jobs:
9090
--check-links-ignore "https://jupytercon.com" \
9191
--check-links-ignore "https://www.netapp.com" \
9292
--check-links-ignore "https://github.com/[^/]+/?$" \
93+
--check-links-ignore "https://sloan.org" \
94+
--check-links-ignore "https://www.bloomberg.com" \
9395
--check-links-ignore "https://opensource.org/licenses/BSD-3-Clause"
9496
9597
lighthouse:

assets/css/main.scss

+13-10
Original file line numberDiff line numberDiff line change
@@ -152,16 +152,19 @@
152152
max-width: 500px;
153153
}
154154

155-
.con-button button {
156-
background-color: #f37726;
157-
color: white;
158-
margin: 0 .5em;
159-
padding: 1em;
160-
border-radius: 5px;
161-
border: none;
162-
font-size: 1em;
163-
font-weight: 600;
164-
cursor: pointer;
155+
div.con-buttons {
156+
margin-top: 2em;
157+
a.con-button {
158+
background-color: #f37726;
159+
color: white;
160+
font-size: 1em;
161+
font-weight: 600;
162+
margin: 0 .5em;
163+
padding: 1em;
164+
border-radius: 5px;
165+
border: none;
166+
cursor: pointer;
167+
}
165168
}
166169

167170

index.html

+4-2
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,10 @@
256256
<div class="con-program">
257257
<p>San Diego, California</p>
258258
</div>
259-
<a class="con-button" href="https://events.linuxfoundation.org/jupytercon/"><button>Conference Website</button></a>
260-
<a class="con-button" href="https://events.linuxfoundation.org/jupytercon/program/cfp/"><button>Call for Proposals</button></a>
259+
<div class="con-buttons">
260+
<a class="con-button" role="button" href="https://events.linuxfoundation.org/jupytercon/">Conference Website</a>
261+
<a class="con-button" role="button" href="https://events.linuxfoundation.org/jupytercon/program/cfp/">Call for Proposals</a>
262+
</div>
261263
</div>
262264
</div>
263265
</div>

0 commit comments

Comments
 (0)