Skip to content

Broken compiler tests #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abitrolly opened this issue Feb 24, 2021 · 1 comment
Open

Broken compiler tests #852

abitrolly opened this issue Feb 24, 2021 · 1 comment

Comments

@abitrolly
Copy link

https://github.com/kaitai-io/kaitai_struct_compiler/commits/master tests are broken since November 2020.

Is there something that could be done to fix them? I see these red lines in the output log, though I am not sure what is the cause.

[info] ProblemCoords$Test:
[info] AttrSpec$Test:
[info] - fails to parse double *** FAILED ***
[info]   io.kaitai.struct.problems.CompilationProblemException: (main): /test: error: unable to parse fixed content: 1.234 had message "(main): /test: error: unable to parse fixed content: 1.234" instead of expected message "/test: error: unable to parse fixed content: 1.234" (AttrSpec$Test.scala:58)
[info] - fails to parse map *** FAILED ***
[info]   io.kaitai.struct.problems.CompilationProblemException: (main): /test: error: unable to parse fixed content: Map(foo -> 123) had message "(main): /test: error: unable to parse fixed content: Map(foo -> 123)" instead of expected message "/test: error: unable to parse fixed content: Map(foo -> 123)" (AttrSpec$Test.scala:63)
[info] - fails to parse bogus array element *** FAILED ***
[info]   io.kaitai.struct.problems.CompilationProblemException: (main): /test/2: error: unable to parse fixed content in array: List(3) had message "(main): /test/2: error: unable to parse fixed content in array: List(3)" instead of expected message "/test/2: error: unable to parse fixed content in array: List(3)" (AttrSpec$Test.scala:68)
[info] SwitchType$Test:
@jhgorse
Copy link

jhgorse commented Jan 28, 2025

Per kaitai-io/kaitai_struct_compiler#255 (comment) @generalmimon, there are tests that don't pass: https://ci.kaitai.io/

@generalmimon, is there a mask or set of core tests we can use, for this project as well as the core Scala compiler (https://github.com/kaitai-io/kaitai_struct_compiler), to get a sense that we are not breaking things that previously worked? Moving this part of yesterday's thread here because it is relevant to this issue and repo as well.

Using test cases to track bugs is good. We can separate those test cases logically so that the rest of the test suite passes and we can assert that we are not breaking the important bits inside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants