Fix paths in "duplicate attribute ID '$ID', previously defined at $PATH" errors

Error count: 58 -> 51 (-7). Fixed:

[info] - id_clash_params_vs_inst_pos *** FAILED ***
[info]   [id_clash_params_vs_inst_pos.ksy: /instances/foo:
[info]          error: duplicate attribute ID 'foo', previously defined at /params/0
[info]   ]
[info]     did not equal
[info]   [id_clash_params_vs_inst_pos.ksy: /instances/foo:
[info]          error: duplicate attribute ID 'foo', previously defined at /params/0/id
[info]   ] (SimpleMatchers.scala:34)
[info] - id_clash_params_vs_inst_value *** FAILED ***
[info]   [id_clash_params_vs_inst_value.ksy: /instances/bar:
[info]          error: duplicate attribute ID 'bar', previously defined at /params/1
[info]   ]
[info]     did not equal
[info]   [id_clash_params_vs_inst_value.ksy: /instances/bar:
[info]          error: duplicate attribute ID 'bar', previously defined at /params/1/id
[info]   ] (SimpleMatchers.scala:34)
[info] - id_clash_params_vs_seq *** FAILED ***
[info]   [id_clash_params_vs_seq.ksy: /seq/0:
[info]          error: duplicate attribute ID 'foo', previously defined at /params/1
[info]   ]
[info]     did not equal
[info]   [id_clash_params_vs_seq.ksy: /seq/0/id:
[info]          error: duplicate attribute ID 'foo', previously defined at /params/1/id
[info]   ] (SimpleMatchers.scala:34)
[info] - id_clash_seq_vs_inst_pos *** FAILED ***
[info]   [id_clash_seq_vs_inst_pos.ksy: /instances/foo:
[info]          error: duplicate attribute ID 'foo', previously defined at /seq/0
[info]   ]
[info]     did not equal
[info]   [id_clash_seq_vs_inst_pos.ksy: /instances/foo:
[info]          error: duplicate attribute ID 'foo', previously defined at /seq/0/id
[info]   ] (SimpleMatchers.scala:34)
[info] - id_clash_seq_vs_inst_value *** FAILED ***
[info]   [id_clash_seq_vs_inst_value.ksy: /instances/bar:
[info]          error: duplicate attribute ID 'bar', previously defined at /seq/1
[info]   ]
[info]     did not equal
[info]   [id_clash_seq_vs_inst_value.ksy: /instances/bar:
[info]          error: duplicate attribute ID 'bar', previously defined at /seq/1/id
[info]   ] (SimpleMatchers.scala:34)
[info] - id_dup_params *** FAILED ***
[info]   [id_dup_params.ksy: /params/2:
[info]          error: duplicate attribute ID 'foo', previously defined at /params/0
[info]   ]
[info]     did not equal
[info]   [id_dup_params.ksy: /params/2/id:
[info]          error: duplicate attribute ID 'foo', previously defined at /params/0/id
[info]   ] (SimpleMatchers.scala:34)
[info] - id_dup_seq *** FAILED ***
[info]   [id_dup_seq.ksy: /seq/2:
[info]          error: duplicate attribute ID 'foo', previously defined at /seq/0
[info]   ]
[info]     did not equal
[info]   [id_dup_seq.ksy: /seq/2/id:
[info]          error: duplicate attribute ID 'foo', previously defined at /seq/0/id
[info]   ] (SimpleMatchers.scala:34)

Author: Mingun

shared/src/main/scala/io/kaitai/struct/format/ClassSpec.scala

@@ -253,9 +253,19 @@ object ClassSpec {
   private def checkDupId(prevAttrOpt: Option[MemberSpec], id: String, nowAttr: YAMLPath): Unit = {
     prevAttrOpt match {
       case Some(prevAttr) =>
+        // Report error at position where referenced param / attribute / instance is defined.
+        // Add `id` for attributes in `seq` and `params`, do not add for instances
+        val path = nowAttr match {
+          case _: InstanceSpec => nowAttr.path
+          case _ => nowAttr.path :+ "id"
+        }
+        val prevPath = prevAttr match {
+          case _: InstanceSpec => prevAttr.path
+          case _ => prevAttr.path :+ "id"
+        }
         throw KSYParseError.withText(
-          s"duplicate attribute ID '$id', previously defined at /${prevAttr.pathStr}",
-          nowAttr.path
+          s"duplicate attribute ID '$id', previously defined at /${prevPath.mkString("/")}",
+          path
         )
       case None =>
         // no dups, ok