Parent not included with requests

[Rasmus-Bertell]

I have this package installed alongside spatie/laravel-query-builder but trying to include the parent with the request does nothing. I opened a discussion on the Query Builder side, but it seems like this is a problem in nested set.

It seems like the problem stems from the fix to an earlier issue¹. While this fix works it seems to have the unintended consequence of removing parent relationship when requesting it and it has led to confusion and multiple issues²³.

I think this fix should be revisited and implemented such that it doesn't interfere with other features.

laravel-nestedset/src/NodeTrait.php

Lines 1078 to 1089 in afb1373

	/**
	* @return array
	*/
	protected function getArrayableRelations()
	{
	$result = parent::getArrayableRelations();
	// To fix #17 when converting tree to json falling to infinite recursion.
	unset($result['parent']);
	return $result;
	}

Footnotes

1. Maximum function nesting level error #17 ↩

2. The 'parent' relationship missing in Model toJson() #507 ↩

3. ->with('parent') do not work #563 ↩

[Rasmus-Bertell]

Just adding to this that trying the requests listed in #17 don't work with deeply nested data.

return Nested::defaultOrder()->get()->toTree();
return Nested::defaultOrder()->get([ 'id' ])->toTree();
return Nested::defaultOrder()->get([ 'id', '_lft', 'parent_id' ])->toTree();

These all result in the same error with current build of Nested Set.

~/Projects/minimal> http get --headers [Accept application/json] --allow-errors http://localhost:8000
╭───────────┬─────────────────────────────────────────────────────────────────────────────────────────────╮
│ message   │ Maximum stack depth exceeded                                                                │
│ exception │ InvalidArgumentException                                                                    │
│ file      │ /home/rasmus/Projects/minimal/vendor/laravel/framework/src/Illuminate/Http/JsonResponse.php │
│ line      │ 89                                                                                          │