Skip to content

Commit 5cbb9eb

Browse files
load latest version if remote comp source is bundle
1 parent 445c6de commit 5cbb9eb

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

client/packages/lowcoder/src/comps/comps/appSettingsComp.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ function AppSettingsModal(props: ChildrenInstance) {
234234
useEffect(() => {
235235
setLowcoderCompVersions([
236236
'latest',
237-
...Object.keys(lowcoderCompsMeta.versions).reverse()
237+
...Object.keys(lowcoderCompsMeta?.versions || []).reverse()
238238
])
239239
}, [lowcoderCompsMeta])
240240

client/packages/lowcoder/src/comps/comps/remoteComp/remoteComp.tsx

+5-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { WhiteLoading } from "lowcoder-design";
88
import { useContext, useState } from "react";
99
import { useMount } from "react-use";
1010
import styled from "styled-components";
11-
import { RemoteCompInfo, RemoteCompLoader } from "types/remoteComp";
11+
import { RemoteCompInfo, RemoteCompLoader, RemoteCompSource } from "types/remoteComp";
1212
import { loaders } from "./loaders";
1313
import { withErrorBoundary } from "comps/generators/withErrorBoundary";
1414
import { EditorContext } from "@lowcoder-ee/comps/editorState";
@@ -54,10 +54,11 @@ interface RemoteCompViewProps {
5454
loadComp: (packageVersion?: string) => Promise<void>;
5555
loadingElement?: () => React.ReactNode;
5656
errorElement?: (error: any) => React.ReactNode;
57+
source?: RemoteCompSource;
5758
}
5859

5960
const RemoteCompView = React.memo((props: React.PropsWithChildren<RemoteCompViewProps>) => {
60-
const { loadComp, loadingElement, errorElement, isLowcoderComp } = props;
61+
const { loadComp, loadingElement, errorElement, isLowcoderComp, source } = props;
6162
const [error, setError] = useState<any>("");
6263
const editorState = useContext(EditorContext);
6364
const compState = useContext(CompContext);
@@ -66,7 +67,7 @@ const RemoteCompView = React.memo((props: React.PropsWithChildren<RemoteCompView
6667

6768
let packageVersion = 'latest';
6869
// lowcoder-comps's package version
69-
if (isLowcoderComp) {
70+
if (isLowcoderComp && source !== 'bundle') {
7071
packageVersion = lowcoderCompPackageVersion === 'latest' && Boolean(latestLowcoderCompsVersion)
7172
? latestLowcoderCompsVersion
7273
: lowcoderCompPackageVersion;
@@ -160,6 +161,7 @@ export function remoteComp<T extends RemoteCompInfo = RemoteCompInfo>(
160161
isLowcoderComp={remoteInfo?.packageName === 'lowcoder-comps'}
161162
loadComp={(packageVersion?: string) => this.load(packageVersion)}
162163
loadingElement={loadingElement}
164+
source={remoteInfo?.source}
163165
/>
164166
);
165167
}

0 commit comments

Comments
 (0)