Skip to content

Commit 6f735e3

Browse files
committed
Resolve the pr comments
1 parent d597687 commit 6f735e3

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

src/Analyzer/SystemXml/Analyzer.php

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -157,14 +157,14 @@ private function getBaseDir($filePath): ?string
157157
return null;
158158
}
159159

160-
/**
161-
* Search for system.xml files in both app/code and vendor directories, excluding the provided file.
162-
*
163-
* @param string $magentoBaseDir The base directory of Magento.
164-
* @param string $excludeFile The file to exclude from the search.
165-
* @return array An array of paths to system.xml files, excluding the specified file.
166-
*/
167-
private function getSystemXmlFiles($magentoBaseDir, $excludeFile = null): array
160+
/**
161+
* Search for system.xml files in both app/code and vendor directories, excluding the provided file.
162+
*
163+
* @param string $magentoBaseDir The base directory of Magento.
164+
* @param string|null $excludeFile The file to exclude from the search.
165+
* @return array An array of paths to system.xml files, excluding the specified file.
166+
*/
167+
private function getSystemXmlFiles(string $magentoBaseDir, ?string $excludeFile = null): array
168168
{
169169
$systemXmlFiles = [];
170170
$directoryToSearch = [
@@ -189,13 +189,13 @@ private function getSystemXmlFiles($magentoBaseDir, $excludeFile = null): array
189189
return $systemXmlFiles;
190190
}
191191

192-
/**
193-
* Method to extract section, group and field from the Node
194-
*
195-
* @param $nodePath
196-
* @return array|null
197-
*/
198-
private function extractSectionGroupField($nodePath): ?array
192+
/**
193+
* Method to extract section, group and field from the Node
194+
*
195+
* @param string $nodePath
196+
* @return array|null
197+
*/
198+
private function extractSectionGroupField(string $nodePath): ?array
199199
{
200200
$parts = explode('/', $nodePath);
201201

@@ -211,14 +211,14 @@ private function extractSectionGroupField($nodePath): ?array
211211
return [$sectionId, $groupId, $fieldId];
212212
}
213213

214-
/**
215-
* Method to get Node Data using reflection class
216-
*
217-
* @param $node
218-
* @return array
219-
* @throws \ReflectionException
220-
*/
221-
private function getNodeData($node): array
214+
/**
215+
* Method to get Node Data using reflection class
216+
*
217+
* @param object|string $node
218+
* @return array
219+
* @throws \ReflectionException
220+
*/
221+
private function getNodeData(object|string $node): array
222222
{
223223
$data = [];
224224

0 commit comments

Comments
 (0)