From f9c995194a19b955aadc8978af75c10c208d90b3 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Mon, 6 Mar 2023 22:22:35 +0000 Subject: [PATCH 1/4] Remove forbidden @author tag --- app/code/Magento/Wishlist/Block/Customer/Sharing.php | 2 -- app/code/Magento/Wishlist/Block/Customer/Wishlist.php | 3 --- app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php | 2 -- .../Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php | 3 --- .../Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php | 3 --- .../Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php | 3 --- .../Wishlist/Block/Customer/Wishlist/Item/Column/Info.php | 3 --- .../Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php | 3 --- app/code/Magento/Wishlist/Block/Share/Wishlist.php | 2 -- app/code/Magento/Wishlist/Helper/Data.php | 1 - app/code/Magento/Wishlist/Model/ResourceModel/Item.php | 2 -- app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php | 2 -- .../Wishlist/Model/ResourceModel/Item/Option/Collection.php | 2 -- app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php | 2 -- .../Wishlist/Model/ResourceModel/Wishlist/Collection.php | 2 -- 15 files changed, 35 deletions(-) diff --git a/app/code/Magento/Wishlist/Block/Customer/Sharing.php b/app/code/Magento/Wishlist/Block/Customer/Sharing.php index 40fd00d6143a5..e4622afbfd681 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Sharing.php +++ b/app/code/Magento/Wishlist/Block/Customer/Sharing.php @@ -6,8 +6,6 @@ /** * Wishlist customer sharing block - * - * @author Magento Core Team */ namespace Magento\Wishlist\Block\Customer; diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist.php index bc94f53a7625a..8d754bc73342d 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * @author Magento Core Team - */ namespace Magento\Wishlist\Block\Customer; /** diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php index d5c77aa5cd6a6..dec0f5718cf4c 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php @@ -6,8 +6,6 @@ /** * Wishlist block customer item cart column - * - * @author Magento Core Team */ namespace Magento\Wishlist\Block\Customer\Wishlist; diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php index db92a10907d39..1e2155abbc3f9 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * @author Magento Core Team - */ namespace Magento\Wishlist\Block\Customer\Wishlist\Item\Column; /** diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php index 57d182dee4e1c..d5aa688f0b0e3 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * @author Magento Core Team - */ namespace Magento\Wishlist\Block\Customer\Wishlist\Item\Column; /** diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php index f41146051ae96..1f07c2e389067 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * @author Magento Core Team - */ namespace Magento\Wishlist\Block\Customer\Wishlist\Item\Column; /** diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php index 092ede9ceb016..78a79924c8f9b 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * @author Magento Core Team - */ namespace Magento\Wishlist\Block\Customer\Wishlist\Item\Column; /** diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php index 472cd3cc70f09..b9be8004f999b 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * @author Magento Core Team - */ namespace Magento\Wishlist\Block\Customer\Wishlist\Item\Column; /** diff --git a/app/code/Magento/Wishlist/Block/Share/Wishlist.php b/app/code/Magento/Wishlist/Block/Share/Wishlist.php index 889fb363a2070..49dd1e7e6ed17 100644 --- a/app/code/Magento/Wishlist/Block/Share/Wishlist.php +++ b/app/code/Magento/Wishlist/Block/Share/Wishlist.php @@ -6,8 +6,6 @@ /** * Wishlist block shared items - * - * @author Magento Core Team */ namespace Magento\Wishlist\Block\Share; diff --git a/app/code/Magento/Wishlist/Helper/Data.php b/app/code/Magento/Wishlist/Helper/Data.php index 99be268041f34..9ea8f246116c6 100644 --- a/app/code/Magento/Wishlist/Helper/Data.php +++ b/app/code/Magento/Wishlist/Helper/Data.php @@ -16,7 +16,6 @@ /** * Wishlist Data Helper * - * @author Magento Core Team * @SuppressWarnings(PHPMD.CouplingBetweenObjects) * @SuppressWarnings(PHPMD.CookieAndSessionMisuse) * diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Item.php b/app/code/Magento/Wishlist/Model/ResourceModel/Item.php index 1cf7ffb3f4bdf..e543fe42ce2c4 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Item.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Item.php @@ -6,8 +6,6 @@ /** * Wishlist item model resource - * - * @author Magento Core Team */ namespace Magento\Wishlist\Model\ResourceModel; diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php b/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php index 43d320b1821d8..fb2dc09948c59 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php @@ -6,8 +6,6 @@ /** * Wishlist item option resource model - * - * @author Magento Core Team */ namespace Magento\Wishlist\Model\ResourceModel\Item; diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option/Collection.php b/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option/Collection.php index dbbe6170ab19c..c1f8072cd0fb3 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option/Collection.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option/Collection.php @@ -6,8 +6,6 @@ /** * Wishlist item option collection - * - * @author Magento Core Team */ namespace Magento\Wishlist\Model\ResourceModel\Item\Option; diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php b/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php index 27953b03aacfb..e0b88d34f973f 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php @@ -6,8 +6,6 @@ /** * Wishlist resource model - * - * @author Magento Core Team */ namespace Magento\Wishlist\Model\ResourceModel; diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist/Collection.php b/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist/Collection.php index a313b5df07167..365625bbd9909 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist/Collection.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist/Collection.php @@ -6,8 +6,6 @@ /** * Wishlist model collection - * - * @author Magento Core Team */ namespace Magento\Wishlist\Model\ResourceModel\Wishlist; From 11669272e13573db1af0644c420600c58e3522d6 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 14 Mar 2023 17:22:47 +0000 Subject: [PATCH 2/4] Fix static test failures --- app/code/Magento/Wishlist/Block/Customer/Sharing.php | 6 +----- .../Magento/Wishlist/Block/Customer/Wishlist/Button.php | 9 ++------- app/code/Magento/Wishlist/Block/Share/Wishlist.php | 1 - app/code/Magento/Wishlist/Model/ResourceModel/Item.php | 7 +++---- .../Magento/Wishlist/Model/ResourceModel/Item/Option.php | 7 ++++--- .../Magento/Wishlist/Model/ResourceModel/Wishlist.php | 7 +++---- 6 files changed, 13 insertions(+), 24 deletions(-) diff --git a/app/code/Magento/Wishlist/Block/Customer/Sharing.php b/app/code/Magento/Wishlist/Block/Customer/Sharing.php index e4622afbfd681..48e84b3486198 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Sharing.php +++ b/app/code/Magento/Wishlist/Block/Customer/Sharing.php @@ -4,19 +4,15 @@ * See COPYING.txt for license details. */ -/** - * Wishlist customer sharing block - */ namespace Magento\Wishlist\Block\Customer; use Magento\Captcha\Block\Captcha; /** - * Class Sharing + * Wishlist customer sharing block * * @api * @since 100.0.2 - * @package Magento\Wishlist\Block\Customer */ class Sharing extends \Magento\Framework\View\Element\Template { diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php index dec0f5718cf4c..510cffde0e88b 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Button.php @@ -4,27 +4,22 @@ * See COPYING.txt for license details. */ -/** - * Wishlist block customer item cart column - */ namespace Magento\Wishlist\Block\Customer\Wishlist; /** + * Wishlist block customer item cart column + * * @api * @since 100.0.2 */ class Button extends \Magento\Framework\View\Element\Template { /** - * Wishlist config - * * @var \Magento\Wishlist\Model\Config */ protected $_wishlistConfig; /** - * Wishlist data - * * @var \Magento\Wishlist\Helper\Data */ protected $_wishlistData = null; diff --git a/app/code/Magento/Wishlist/Block/Share/Wishlist.php b/app/code/Magento/Wishlist/Block/Share/Wishlist.php index 49dd1e7e6ed17..5ac40885e75c0 100644 --- a/app/code/Magento/Wishlist/Block/Share/Wishlist.php +++ b/app/code/Magento/Wishlist/Block/Share/Wishlist.php @@ -51,7 +51,6 @@ public function __construct( * Prepare global layout * * @return $this - * */ protected function _prepareLayout() { diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Item.php b/app/code/Magento/Wishlist/Model/ResourceModel/Item.php index e543fe42ce2c4..c56e960ab79c0 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Item.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Item.php @@ -4,12 +4,11 @@ * See COPYING.txt for license details. */ -/** - * Wishlist item model resource - */ namespace Magento\Wishlist\Model\ResourceModel; /** + * Wishlist item model resource + * * @api * @since 100.0.2 */ @@ -54,7 +53,7 @@ public function loadByProductWishlist($object, $wishlistId, $productId, $sharedS } /** - * {@inheritdoc} + * @inheritDoc */ public function save(\Magento\Framework\Model\AbstractModel $object) { diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php b/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php index fb2dc09948c59..ffec9a86327e9 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Item/Option.php @@ -4,18 +4,19 @@ * See COPYING.txt for license details. */ -/** - * Wishlist item option resource model - */ namespace Magento\Wishlist\Model\ResourceModel\Item; /** + * Wishlist item option resource model + * * @api * @since 100.0.2 */ class Option extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb { /** + * Initialise the resource model + * * @return void */ protected function _construct() diff --git a/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php b/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php index e0b88d34f973f..e2047faa6dbb2 100644 --- a/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php +++ b/app/code/Magento/Wishlist/Model/ResourceModel/Wishlist.php @@ -4,12 +4,11 @@ * See COPYING.txt for license details. */ -/** - * Wishlist resource model - */ namespace Magento\Wishlist\Model\ResourceModel; /** + * Wishlist resource model + * * @api * @since 100.0.2 */ @@ -79,7 +78,7 @@ public function setCustomerIdFieldName($fieldName) } /** - * {@inheritdoc} + * @inheritDoc */ public function save(\Magento\Framework\Model\AbstractModel $object) { From c1f19d18d862ff68c234f4016912647630d3e9bf Mon Sep 17 00:00:00 2001 From: engcom-Echo Date: Mon, 25 Sep 2023 13:07:08 +0530 Subject: [PATCH 3/4] Fixed static test failure --- .../Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php | 1 + .../Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php | 1 + .../Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php | 1 + .../Wishlist/Block/Customer/Wishlist/Item/Column/Info.php | 1 + 4 files changed, 4 insertions(+) diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php index 1e2155abbc3f9..cd5ecdffc9ca1 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Actions.php @@ -11,6 +11,7 @@ * * @api * @deprecated 101.1.2 + * @see no longer used * @since 100.0.2 */ class Actions extends \Magento\Wishlist\Block\Customer\Wishlist\Item\Column diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php index d5aa688f0b0e3..276d5a6c1cac2 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Comment.php @@ -11,6 +11,7 @@ * * @api * @deprecated 101.1.2 + * @see no longer used * @since 100.0.2 */ class Comment extends \Magento\Wishlist\Block\Customer\Wishlist\Item\Column diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php index 1f07c2e389067..80b09920d8ac0 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Edit.php @@ -11,6 +11,7 @@ * * @api * @deprecated 101.1.2 + * @see no longer used * @since 100.0.2 */ class Edit extends \Magento\Wishlist\Block\Customer\Wishlist\Item\Column diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php index 78a79924c8f9b..61a6a882c422d 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Info.php @@ -11,6 +11,7 @@ * * @api * @deprecated 101.1.2 + * @see no longer used * @since 100.0.2 */ class Info extends \Magento\Wishlist\Block\Customer\Wishlist\Item\Column From 55d8416a4fa1c70c13ff21ae07aeab11a166e77d Mon Sep 17 00:00:00 2001 From: engcom-Echo Date: Mon, 25 Sep 2023 14:08:04 +0530 Subject: [PATCH 4/4] Fixed static tests --- .../Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php index b9be8004f999b..ad6d84280d35a 100644 --- a/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php +++ b/app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Remove.php @@ -11,6 +11,7 @@ * * @api * @deprecated 101.1.2 + * @see no longer used * @since 100.0.2 */ class Remove extends \Magento\Wishlist\Block\Customer\Wishlist\Item\Column