perf(18/2024): optimize removing redundant cloning

manhunto · manhunto · commit 51650999efd2 · 2024-12-20T19:34:50.000+01:00
diff --git a/readme.md b/readme.md
@@ -28,7 +28,7 @@
 | [Day 15: Warehouse Woes](src/solutions/year2024/day15.rs)         |   ⭐⭐   |            7.226 |            9.084 |
 | [Day 16: Reindeer Maze](src/solutions/year2024/day16.rs)          |   ⭐    |            6.478 |                - |
 | [Day 17: Chronospatial Computer](src/solutions/year2024/day17.rs) |   -    |                - |                - |
-| [Day 18: RAM Run](src/solutions/year2024/day18.rs)                |   ⭐⭐   |            2.487 |         431.665a |
+| [Day 18: RAM Run](src/solutions/year2024/day18.rs)                |   ⭐⭐   |            2.487 |          379.772 |
 | [Day 19: Linen Layout](src/solutions/year2024/day19.rs)           |   ⭐⭐   |            2.923 |           22.751 |
 
 # 2023
diff --git a/src/solutions/year2024/day18.rs b/src/solutions/year2024/day18.rs
@@ -88,14 +88,8 @@ impl Day18 {
                 return true;
             }
 
-            let neighbours: Vec<Point> = current
-                .adjacent()
-                .into_iter()
-                .filter(|p| !blocked.contains(p) && self.surface.contains(*p))
-                .collect();
-
-            for next in neighbours {
-                if visited.insert(next) {
+            for next in current.adjacent() {
+                if visited.insert(next) && self.surface.contains(next) && !blocked.contains(&next) {
                     queue.push(next);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -88,14 +88,8 @@ impl Day18 {`
`88`	`88`	`return true;`
`89`	`89`	`}`
`90`	`90`
`91`		`- let neighbours: Vec<Point> = current`
`92`		`- .adjacent()`
`93`		`- .into_iter()`
`94`		`- .filter(\|p\| !blocked.contains(p) && self.surface.contains(*p))`
`95`		`- .collect();`
`96`		`-`
`97`		`- for next in neighbours {`
`98`		`- if visited.insert(next) {`
	`91`	`+ for next in current.adjacent() {`
	`92`	`+ if visited.insert(next) && self.surface.contains(next) && !blocked.contains(&next) {`
`99`	`93`	`queue.push(next);`
`100`	`94`	`}`
`101`	`95`	`}`