Skip to content

Commit d910a94

Browse files
committed
small code simplification
1 parent f3275cf commit d910a94

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

src/Enum.php

+4-8
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,10 @@ final public static function get($value)
167167
$constants = self::detectConstants($class);
168168
$name = array_search($value, $constants, true);
169169
if ($name === false) {
170-
if (is_scalar($value)) {
171-
throw new InvalidArgumentException('Unknown value ' . var_export($value, true));
172-
} else {
173-
throw new InvalidArgumentException(sprintf(
174-
'Invalid value of type %s',
175-
is_object($value) ? get_class($value) : gettype($value)
176-
));
177-
}
170+
$message = is_scalar($value)
171+
? 'Unknown value ' . var_export($value, true)
172+
: 'Invalid value of type ' . (is_object($value) ? get_class($value) : gettype($value));
173+
throw new InvalidArgumentException($message);
178174
}
179175

180176
if (!isset(self::$instances[$class][$name])) {

src/EnumSerializableTrait.php

+3-5
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,9 @@ public function unserialize($serialized)
4949
$constants = self::getConstants();
5050
$name = array_search($value, $constants, true);
5151
if ($name === false) {
52-
if (is_scalar($value)) {
53-
$message = 'Unknown value ' . var_export($value, true);
54-
} else {
55-
$message = 'Invalid value of type ' . (is_object($value) ? get_class($value) : gettype($value));
56-
}
52+
$message = is_scalar($value)
53+
? 'Unknown value ' . var_export($value, true)
54+
: 'Invalid value of type ' . (is_object($value) ? get_class($value) : gettype($value));
5755
throw new RuntimeException($message);
5856
}
5957

0 commit comments

Comments
 (0)