gameplay: ceil damage to buildings

mastercoms · mastercoms · commit 3b36fc3e26da · 2023-04-11T00:50:19.000-04:00
due to an oversight, damage is automatically truncated instead of being rounded up like player damage ref: ValveSoftware/Source-1-Games#4364
diff --git a/src/game/server/tf/tf_obj.cpp b/src/game/server/tf/tf_obj.cpp
@@ -1942,6 +1942,9 @@ int CBaseObject::OnTakeDamage( const CTakeDamageInfo &info )
 		break;
 	}
 
+	// Round up damage like players
+	flDamage = Ceil2Int( flDamage );
+
 	// Don't look, Tom Bui!
 	static struct
 	{
@@ -1978,7 +1981,7 @@ int CBaseObject::OnTakeDamage( const CTakeDamageInfo &info )
 
 	if ( flDamage )
 	{
-		m_iLifetimeDamage += floor( MIN( flDamage, m_flHealth ) );
+		m_iLifetimeDamage += Floor2Int( MIN( flDamage, m_flHealth ) );
 		if ( m_iLifetimeDamage > tf_obj_damage_tank_achievement_amount.GetInt() && GetBuilder() )
 		{
 			GetBuilder()->AwardAchievement( ACHIEVEMENT_TF_ENGINEER_TANK_DAMAGE );

Original file line number	Diff line number	Diff line change
`@@ -1942,6 +1942,9 @@ int CBaseObject::OnTakeDamage( const CTakeDamageInfo &info )`
`1942`	`1942`	`break;`
`1943`	`1943`	`}`
`1944`	`1944`
	`1945`	`+ // Round up damage like players`
	`1946`	`+ flDamage = Ceil2Int( flDamage );`
	`1947`	`+`
`1945`	`1948`	`// Don't look, Tom Bui!`
`1946`	`1949`	`static struct`
`1947`	`1950`	`{`
`@@ -1978,7 +1981,7 @@ int CBaseObject::OnTakeDamage( const CTakeDamageInfo &info )`
`1978`	`1981`
`1979`	`1982`	`if ( flDamage )`
`1980`	`1983`	`{`
`1981`		`- m_iLifetimeDamage += floor( MIN( flDamage, m_flHealth ) );`
	`1984`	`+ m_iLifetimeDamage += Floor2Int( MIN( flDamage, m_flHealth ) );`
`1982`	`1985`	`if ( m_iLifetimeDamage > tf_obj_damage_tank_achievement_amount.GetInt() && GetBuilder() )`
`1983`	`1986`	`{`
`1984`	`1987`	`GetBuilder()->AwardAchievement( ACHIEVEMENT_TF_ENGINEER_TANK_DAMAGE );`