Skip to content

Commit 09c99a9

Browse files
author
Sourcery AI
committed
'Refactored by Sourcery'
1 parent f909377 commit 09c99a9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+1239
-1491
lines changed

discord/__main__.py

+12-11
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,9 @@ def show_version():
4242
version_info = discord.version_info
4343
entries.append('- discord.py-message-components v{0.major}.{0.minor}.{0.micro}-{0.releaselevel}'.format(version_info))
4444
if version_info.releaselevel != 'final':
45-
version = importlib_metadata.version('discord.py-message-components')
46-
if version:
45+
if version := importlib_metadata.version(
46+
'discord.py-message-components'
47+
):
4748
entries.append(' - discord.py.message-components metadata: v{0}'.format(version))
4849

4950
entries.append('- aiohttp v{0.__version__}'.format(aiohttp))
@@ -177,7 +178,7 @@ async def cog_after_invoke(self, ctx):
177178
}
178179

179180
# NUL (0) and 1-31 are disallowed
180-
_base_table.update((chr(i), None) for i in range(32))
181+
_base_table |= ((chr(i), None) for i in range(32))
181182

182183
translation_table = str.maketrans(_base_table)
183184

@@ -206,7 +207,7 @@ def newbot(parser, args):
206207
try:
207208
new_directory.mkdir(exist_ok=True, parents=True)
208209
except OSError as exc:
209-
parser.error('could not create our bot directory ({})'.format(exc))
210+
parser.error(f'could not create our bot directory ({exc})')
210211

211212
cogs = new_directory / 'cogs'
212213

@@ -215,27 +216,27 @@ def newbot(parser, args):
215216
init = cogs / '__init__.py'
216217
init.touch()
217218
except OSError as exc:
218-
print('warning: could not create cogs directory ({})'.format(exc))
219+
print(f'warning: could not create cogs directory ({exc})')
219220

220221
try:
221222
with open(str(new_directory / 'config.py'), 'w', encoding='utf-8') as fp:
222223
fp.write('token = "place your token here"\ncogs = []\n')
223224
except OSError as exc:
224-
parser.error('could not create config file ({})'.format(exc))
225+
parser.error(f'could not create config file ({exc})')
225226

226227
try:
227228
with open(str(new_directory / 'bot.py'), 'w', encoding='utf-8') as fp:
228229
base = 'Bot' if not args.sharded else 'AutoShardedBot'
229230
fp.write(bot_template.format(base=base, prefix=args.prefix))
230231
except OSError as exc:
231-
parser.error('could not create bot file ({})'.format(exc))
232+
parser.error(f'could not create bot file ({exc})')
232233

233234
if not args.no_git:
234235
try:
235236
with open(str(new_directory / '.gitignore'), 'w', encoding='utf-8') as fp:
236237
fp.write(gitignore_template)
237238
except OSError as exc:
238-
print('warning: could not create .gitignore file ({})'.format(exc))
239+
print(f'warning: could not create .gitignore file ({exc})')
239240

240241
print('successfully made bot at', new_directory)
241242

@@ -245,7 +246,7 @@ def newcog(parser, args):
245246
try:
246247
cog_dir.mkdir(exist_ok=True)
247248
except OSError as exc:
248-
print('warning: could not create cogs directory ({})'.format(exc))
249+
print(f'warning: could not create cogs directory ({exc})')
249250

250251
directory = cog_dir / to_path(parser, args.name)
251252
directory = directory.with_suffix('.py')
@@ -264,12 +265,12 @@ def newcog(parser, args):
264265
name = name.title()
265266

266267
if args.display_name:
267-
attrs += ', name="{}"'.format(args.display_name)
268+
attrs += f', name="{args.display_name}"'
268269
if args.hide_commands:
269270
attrs += ', command_attrs=dict(hidden=True)'
270271
fp.write(cog_template.format(name=name, extra=extra, attrs=attrs))
271272
except OSError as exc:
272-
parser.error('could not create cog file ({})'.format(exc))
273+
parser.error(f'could not create cog file ({exc})')
273274
else:
274275
print('successfully made cog at', directory)
275276

discord/abc.py

+23-31
Original file line numberDiff line numberDiff line change
@@ -147,19 +147,19 @@ def mention(self):
147147

148148
@classmethod
149149
def __subclasshook__(cls, C):
150-
if cls is User:
151-
if Snowflake.__subclasshook__(C) is NotImplemented:
152-
return NotImplemented
150+
if cls is not User:
151+
return NotImplemented
152+
if Snowflake.__subclasshook__(C) is NotImplemented:
153+
return NotImplemented
153154

154-
mro = C.__mro__
155-
for attr in ('display_name', 'mention', 'name', 'avatar', 'discriminator', 'bot'):
156-
for base in mro:
157-
if attr in base.__dict__:
158-
break
159-
else:
160-
return NotImplemented
161-
return True
162-
return NotImplemented
155+
mro = C.__mro__
156+
for attr in ('display_name', 'mention', 'name', 'avatar', 'discriminator', 'bot'):
157+
for base in mro:
158+
if attr in base.__dict__:
159+
break
160+
else:
161+
return NotImplemented
162+
return True
163163

164164

165165
class PrivateChannel(metaclass=abc.ABCMeta):
@@ -186,10 +186,7 @@ def __subclasshook__(cls, C):
186186
return NotImplemented
187187

188188
mro = C.__mro__
189-
for base in mro:
190-
if 'me' in base.__dict__:
191-
return True
192-
return NotImplemented
189+
return next((True for base in mro if 'me' in base.__dict__), NotImplemented)
193190
return NotImplemented
194191

195192

@@ -324,14 +321,10 @@ async def _edit(self, options, reason):
324321
payload = {
325322
'allow': allow.value,
326323
'deny': deny.value,
327-
'id': target.id
324+
'id': target.id,
325+
'type': 'role' if isinstance(target, Role) else 'member',
328326
}
329327

330-
if isinstance(target, Role):
331-
payload['type'] = 'role'
332-
else:
333-
payload['type'] = 'member'
334-
335328
perms.append(payload)
336329
options['permission_overwrites'] = perms
337330

@@ -356,7 +349,9 @@ def _fill_overwrites(self, data):
356349
for index, overridden in enumerate(data.get('permission_overwrites', [])):
357350
overridden_type = try_enum(PermissionType, overridden.pop('type'))
358351
if not isinstance(overridden_type, PermissionType):
359-
raise AttributeError('Type type should be 0 - member, or 1 - role not %s' % overridden_type)
352+
raise AttributeError(
353+
f'Type type should be 0 - member, or 1 - role not {overridden_type}'
354+
)
360355
overridden_id = int(overridden.pop('id'))
361356
self._overwrites.append(_Overwrites(id=overridden_id, type=overridden_type.name, **overridden))
362357

@@ -371,9 +366,7 @@ def _fill_overwrites(self, data):
371366
# swap it to be the first one.
372367
everyone_index = index
373368

374-
# do the swap
375-
tmp = self._overwrites
376-
if tmp:
369+
if tmp := self._overwrites:
377370
tmp[everyone_index], tmp[0] = tmp[0], tmp[everyone_index]
378371

379372
@property
@@ -395,7 +388,7 @@ def changed_roles(self):
395388
@property
396389
def mention(self):
397390
""":class:`str`: The string that allows you to mention the channel."""
398-
return '<#%s>' % self.id
391+
return f'<#{self.id}>'
399392

400393
@property
401394
def jump_url(self):
@@ -694,15 +687,14 @@ async def set_permissions(
694687
raise InvalidArgument(f'target parameter must be either Member or Role, not {target.__class__.__name__}')
695688

696689
if isinstance(overwrite, _Undefined):
697-
if len(permissions) == 0:
690+
if not permissions:
698691
raise InvalidArgument('No overwrite provided.')
699692
try:
700693
overwrite = PermissionOverwrite(**permissions)
701694
except (ValueError, TypeError):
702695
raise InvalidArgument('Invalid permissions given to keyword arguments.')
703-
else:
704-
if len(permissions) > 0:
705-
raise InvalidArgument('Cannot mix overwrite and keyword arguments.')
696+
elif permissions:
697+
raise InvalidArgument('Cannot mix overwrite and keyword arguments.')
706698

707699
# TODO: wait for event
708700

discord/activity.py

+8-16
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,7 @@ def __init__(self, **kwargs):
194194
self.session_id = kwargs.pop('session_id', None)
195195
self.type = try_enum(ActivityType, kwargs.pop('type', -1))
196196
emoji = kwargs.pop('emoji', None)
197-
if emoji is not None:
198-
self.emoji = PartialEmoji.from_dict(emoji)
199-
else:
200-
self.emoji = None
197+
self.emoji = PartialEmoji.from_dict(emoji) if emoji is not None else None
201198

202199
def __repr__(self):
203200
attrs = (
@@ -210,7 +207,7 @@ def __repr__(self):
210207
'emoji',
211208
)
212209
mapped = ' '.join('%s=%r' % (attr, getattr(self, attr)) for attr in attrs)
213-
return '<Activity %s>' % mapped
210+
return f'<Activity {mapped}>'
214211

215212
def to_dict(self):
216213
ret = {}
@@ -338,9 +335,9 @@ def _extract_timestamp(self, data, key):
338335
try:
339336
dt = data[key]
340337
except KeyError:
341-
setattr(self, '_' + key, 0)
338+
setattr(self, f'_{key}', 0)
342339
else:
343-
setattr(self, '_' + key, dt.timestamp() * 1000.0)
340+
setattr(self, f'_{key}', dt.timestamp() * 1000.0)
344341

345342
@property
346343
def type(self):
@@ -632,7 +629,7 @@ def album_cover_url(self):
632629
if large_image[:8] != 'spotify:':
633630
return ''
634631
album_image_id = large_image[8:]
635-
return 'https://i.scdn.co/image/' + album_image_id
632+
return f'https://i.scdn.co/image/{album_image_id}'
636633

637634
@property
638635
def track_id(self):
@@ -751,12 +748,9 @@ def __hash__(self):
751748
return hash((self.name, str(self.emoji)))
752749

753750
def __str__(self):
754-
if self.emoji:
755-
if self.name:
756-
return '%s %s' % (self.emoji, self.name)
757-
return str(self.emoji)
758-
else:
751+
if not self.emoji:
759752
return str(self.name)
753+
return f'{self.emoji} {self.name}' if self.name else str(self.emoji)
760754

761755
def __repr__(self):
762756
return '<CustomActivity name={0.name!r} emoji={0.emoji!r}>'.format(self)
@@ -779,9 +773,7 @@ def create_activity(data):
779773
else:
780774
return CustomActivity(name=name, **data)
781775
elif game_type is ActivityType.streaming:
782-
if 'url' in data:
783-
return Streaming(**data)
784-
return Activity(**data)
776+
return Streaming(**data) if 'url' in data else Activity(**data)
785777
elif game_type is ActivityType.listening and 'sync_id' in data and 'session_id' in data:
786778
return Spotify(**data)
787779
return Activity(**data)

0 commit comments

Comments
 (0)