re-iterate

Author: mxschmitt

packages/playwright/src/common/testLoader.ts

@@ -82,7 +82,7 @@ export async function loadTestFile(file: string, rootDir: string, testErrors?: T
   return suite;
 }
 
-export function serializeLoadError(file: string, error: Error | any): TestError {
+function serializeLoadError(file: string, error: Error | any): TestError {
   if (error instanceof Error) {
     const result: TestError = filterStackTrace(error);
     // Babel parse errors have location.

packages/playwright/src/runner/testServer.ts

@@ -29,7 +29,7 @@ import { Watcher } from '../fsWatcher';
 import { baseFullConfig } from '../isomorphic/teleReceiver';
 import { addGitCommitInfoPlugin } from '../plugins/gitCommitInfoPlugin';
 import { webServerPluginsForConfig } from '../plugins/webServerPlugin';
-import { internalScreen } from '../reporters/base';
+import { internalScreen, prepareErrorStack } from '../reporters/base';
 import { InternalReporter } from '../reporters/internalReporter';
 import ListReporter from '../reporters/list';
 import { affectedTestFiles, collectAffectedTestFiles, dependenciesForTestFile } from '../transform/compilationCache';
@@ -43,7 +43,6 @@ import type { TestRunnerPluginRegistration } from '../plugins';
 import type { ReporterV2 } from '../reporters/reporterV2';
 import type { TraceViewerRedirectOptions, TraceViewerServerOptions } from 'playwright-core/lib/server/trace/viewer/traceViewer';
 import type { HttpServer, Transport } from 'playwright-core/lib/utils';
-import { serializeLoadError } from '../common/testLoader';
 
 const originalStdoutWrite = process.stdout.write;
 const originalStderrWrite = process.stderr.write;
@@ -419,7 +418,17 @@ export class TestServerDispatcher implements TestServerInterface {
       }
       return { config };
     } catch (e) {
-      return { config: null, error: this._configLocation.resolvedConfigFile ? serializeLoadError(this._configLocation.resolvedConfigFile, e) : serializeError(e) };
+      const error: reporterTypes.TestError = serializeError(e);
+      if (e.name === 'SyntaxError' && e.code === 'BABEL_PARSE_ERROR' && this._configLocation.resolvedConfigFile) {
+        error.location = {
+          file: this._configLocation.resolvedConfigFile,
+          line: e.loc?.line,
+          column: e.loc?.column,
+        };
+      } else {
+        error.location = prepareErrorStack(e.stack).location;
+      }
+      return { config: null, error };
     }
   }
 

tests/playwright-test/test-server.spec.ts

@@ -145,6 +145,51 @@ test('should list tests with testIdAttribute', async ({ startTestServer, writeFi
   expect(onProject.use.testIdAttribute).toBe('testId');
 });
 
+test('should serialize exception if config throws error', async ({ startTestServer, writeFiles }) => {
+  await writeFiles({
+    'playwright.config.ts': `
+      throw new Error('Config error');
+    `,
+  });
+
+  const testServerConnection = await startTestServer();
+  const events = await testServerConnection.listFiles({});
+  const error = events.report.find(e => e.method === 'onError').params.error;
+  expect(error).toEqual({
+    message: expect.stringContaining('Config error'),
+    location: {
+      file: expect.stringContaining('playwright.config.ts'),
+      line: 2,
+      column: 13,
+    },
+    snippet: expect.anything(),
+    stack: expect.stringContaining('Error: Config error'),
+  });
+});
+
+
+test('should serialize exception if config has SyntaxError', async ({ startTestServer, writeFiles }) => {
+  await writeFiles({
+    'playwright.config.ts': `
+      Invalid syntax
+    `,
+  });
+
+  const testServerConnection = await startTestServer();
+  const events = await testServerConnection.listFiles({});
+  const error = events.report.find(e => e.method === 'onError').params.error;
+  expect(error).toEqual({
+    message: expect.stringMatching(/SyntaxError: .*playwright\.config\.ts: Missing semicolon/),
+    location: {
+      file: expect.stringContaining('playwright.config.ts'),
+      line: 2,
+      column: 13,
+    },
+    snippet: expect.anything(),
+    stack: expect.stringMatching(/SyntaxError: .*playwright\.config\.ts: Missing semicolon/),
+  });
+});
+
 test('stdio interception', async ({ startTestServer, writeFiles }) => {
   const testServerConnection = await startTestServer();
   await testServerConnection.initialize({ interceptStdio: true });