Skip to content

Frequently getting all conflicts have been resolved after clicking Resolve conflicts #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyriar opened this issue Apr 23, 2024 · 3 comments · Fixed by #5955
Closed

Frequently getting all conflicts have been resolved after clicking Resolve conflicts #5952

Tyriar opened this issue Apr 23, 2024 · 3 comments · Fixed by #5955
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 23, 2024

Testing #5939

microsoft/vscode#195255

image

Can we merge this diff automatically but only do it when requested, and .com can't?

image


Another example:

microsoft/vscode#195255

Recording 2024-04-23 at 11 49 07

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Apr 24, 2024
@alexr00 alexr00 added this to the April 2024 milestone Apr 24, 2024
@alexr00
Copy link
Member

alexr00 commented Apr 24, 2024

This is the 300 file limit. New behavior will be to show this error dialog (and it will be faster):

image

@andreamah
Copy link

@Tyriar is this still happening for you?

@alexr00
Copy link
Member

alexr00 commented Apr 26, 2024

Anyone can verify this by opening one of the examples in the OP in insiders.vscode.dev:

  • Make sure you have the pre-release version of the extension installed
  • Set "githubPullRequests.experimentalUpdateBranchWithGitHub": true
  • Open the PR description and scroll down to click on the "resolve conflicts" button
  • Verify that a message shows saying that this conflict can't be resolved here.

@Tyriar Tyriar added the verified Verification succeeded label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
3 participants