Skip to content

Show some loading indicator when switching PR descriptions #5954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tyriar opened this issue Apr 23, 2024 · 1 comment · Fixed by #5960
Closed

Show some loading indicator when switching PR descriptions #5954

Tyriar opened this issue Apr 23, 2024 · 1 comment · Fixed by #5960
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 23, 2024

Testing #5939

Repro:

  1. Open GHPR view
  2. Click the description of a PR
  3. Click the description of another PR, 🐛 nothing happens for ~2 seconds and then the custom editor switches suddenly. Could we show a loading indicator here?

Recording 2024-04-23 at 11 58 22
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Apr 24, 2024
@alexr00 alexr00 added this to the April 2024 milestone Apr 24, 2024
@alexr00
Copy link
Member

alexr00 commented Apr 24, 2024 •
edited
Loading

Adding view progress on the "Pull Requests" view.

alexr00 added a commit that referenced this issue Apr 24, 2024
@alexr00
Show some loading indicator when switching PR descriptions
0f4ee24 
Fixes #5954
@alexr00 alexr00 mentioned this issue Apr 24, 2024
Merged
alexr00 added a commit that referenced this issue Apr 24, 2024
@alexr00
Show some loading indicator when switching PR descriptions (#5960)
e84e8be 
Fixes #5954
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

Show some loading indicator when switching PR descriptions microsoft/vscode-pull-request-github
3 participants
@Tyriar @eleanorjboyd @alexr00