Skip to content

Commit de71ab2

Browse files
committed
Reformat code
1 parent 030f7b1 commit de71ab2

18 files changed

+210
-496
lines changed

.pylintrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ indent-after-paren=4
267267
indent-string=' '
268268

269269
# Maximum number of characters on a single line.
270-
max-line-length=100
270+
max-line-length=99
271271

272272
# Maximum number of lines in a module.
273273
max-module-lines=1000

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,4 @@ script:
2727
- pipenv run bandit ./bot.py cogs/*.py core/*.py -b .bandit_baseline.json
2828
- pipenv run python .lint.py
2929
- pipenv run flake8 ./bot.py cogs/*.py core/*.py --ignore=E501,E203,W503 --exit-zero
30+
- pipenv run black . --check

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ however, insignificant breaking changes does not guarantee a major version bump,
1414
- "enable" and "disable" support for yes or no config vars.
1515
- Added "perhaps you meant" section to `?config help`.
1616

17+
### Internal
18+
19+
- Commit to black format line width max = 99, consistent with pylint.
20+
1721
# v3.3.0
1822

1923

bot.py

+26-67
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919
from aiohttp import ClientSession
2020
from emoji import UNICODE_EMOJI
2121
from motor.motor_asyncio import AsyncIOMotorClient
22-
from pkg_resources import parse_version
2322
from pymongo.errors import ConfigurationError
2423

24+
from pkg_resources import parse_version
25+
2526
try:
2627
# noinspection PyUnresolvedReferences
2728
from colorama import init
@@ -171,9 +172,7 @@ def run(self, *args, **kwargs):
171172
for task in asyncio.all_tasks(self.loop):
172173
task.cancel()
173174
try:
174-
self.loop.run_until_complete(
175-
asyncio.gather(*asyncio.all_tasks(self.loop))
176-
)
175+
self.loop.run_until_complete(asyncio.gather(*asyncio.all_tasks(self.loop)))
177176
except asyncio.CancelledError:
178177
logger.debug("All pending tasks has been cancelled.")
179178
finally:
@@ -187,9 +186,7 @@ def owner_ids(self):
187186
owner_ids = set(map(int, str(owner_ids).split(",")))
188187
if self.owner_id is not None:
189188
owner_ids.add(self.owner_id)
190-
permissions = self.config["level_permissions"].get(
191-
PermissionLevel.OWNER.name, []
192-
)
189+
permissions = self.config["level_permissions"].get(PermissionLevel.OWNER.name, [])
193190
for perm in permissions:
194191
owner_ids.add(int(perm))
195192
return owner_ids
@@ -216,8 +213,7 @@ def log_channel(self) -> typing.Optional[discord.TextChannel]:
216213
channel = self.main_category.channels[0]
217214
self.config["log_channel_id"] = channel.id
218215
logger.warning(
219-
"No log channel set, setting #%s to be the log channel.",
220-
channel.name,
216+
"No log channel set, setting #%s to be the log channel.", channel.name
221217
)
222218
return channel
223219
except IndexError:
@@ -302,9 +298,7 @@ def main_category(self) -> typing.Optional[discord.CategoryChannel]:
302298
category_id = self.config["main_category_id"]
303299
if category_id is not None:
304300
try:
305-
cat = discord.utils.get(
306-
self.modmail_guild.categories, id=int(category_id)
307-
)
301+
cat = discord.utils.get(self.modmail_guild.categories, id=int(category_id))
308302
if cat is not None:
309303
return cat
310304
except ValueError:
@@ -354,9 +348,7 @@ def command_perm(self, command_name: str) -> PermissionLevel:
354348
try:
355349
return PermissionLevel[level.upper()]
356350
except KeyError:
357-
logger.warning(
358-
"Invalid override_command_level for command %s.", command_name
359-
)
351+
logger.warning("Invalid override_command_level for command %s.", command_name)
360352
self.config["override_command_level"].pop(command_name)
361353

362354
command = self.get_command(command_name)
@@ -405,11 +397,7 @@ async def setup_indexes(self):
405397
logger.info('Creating "text" index for logs collection.')
406398
logger.info("Name: %s", index_name)
407399
await coll.create_index(
408-
[
409-
("messages.content", "text"),
410-
("messages.author.name", "text"),
411-
("key", "text"),
412-
]
400+
[("messages.content", "text"), ("messages.author.name", "text"), ("key", "text")]
413401
)
414402
logger.debug("Successfully configured and verified database indexes.")
415403

@@ -428,8 +416,7 @@ async def on_ready(self):
428416
logger.info("Logged in as: %s", self.user)
429417
logger.info("Bot ID: %s", self.user.id)
430418
owners = ", ".join(
431-
getattr(self.get_user(owner_id), "name", str(owner_id))
432-
for owner_id in self.owner_ids
419+
getattr(self.get_user(owner_id), "name", str(owner_id)) for owner_id in self.owner_ids
433420
)
434421
logger.info("Owners: %s", owners)
435422
logger.info("Prefix: %s", self.prefix)
@@ -447,9 +434,7 @@ async def on_ready(self):
447434
logger.line()
448435

449436
for recipient_id, items in tuple(closures.items()):
450-
after = (
451-
datetime.fromisoformat(items["time"]) - datetime.utcnow()
452-
).total_seconds()
437+
after = (datetime.fromisoformat(items["time"]) - datetime.utcnow()).total_seconds()
453438
if after < 0:
454439
after = 0
455440

@@ -475,9 +460,7 @@ async def on_ready(self):
475460

476461
for log in await self.api.get_open_logs():
477462
if self.get_channel(int(log["channel_id"])) is None:
478-
logger.debug(
479-
"Unable to resolve thread with channel %s.", log["channel_id"]
480-
)
463+
logger.debug("Unable to resolve thread with channel %s.", log["channel_id"])
481464
log_data = await self.api.post_log(
482465
log["channel_id"],
483466
{
@@ -494,13 +477,10 @@ async def on_ready(self):
494477
},
495478
)
496479
if log_data:
497-
logger.debug(
498-
"Successfully closed thread with channel %s.", log["channel_id"]
499-
)
480+
logger.debug("Successfully closed thread with channel %s.", log["channel_id"])
500481
else:
501482
logger.debug(
502-
"Failed to close thread with channel %s, skipping.",
503-
log["channel_id"],
483+
"Failed to close thread with channel %s, skipping.", log["channel_id"]
504484
)
505485

506486
self.metadata_loop = tasks.Loop(
@@ -550,9 +530,7 @@ async def retrieve_emoji(self) -> typing.Tuple[str, str]:
550530

551531
return sent_emoji, blocked_emoji
552532

553-
async def _process_blocked(
554-
self, message: discord.Message
555-
) -> typing.Tuple[bool, str]:
533+
async def _process_blocked(self, message: discord.Message) -> typing.Tuple[bool, str]:
556534
sent_emoji, blocked_emoji = await self.retrieve_emoji()
557535

558536
if str(message.author.id) in self.blocked_whitelisted_users:
@@ -597,18 +575,15 @@ async def _process_blocked(
597575
logger.debug("Blocked due to account age, user %s.", message.author.name)
598576

599577
if str(message.author.id) not in self.blocked_users:
600-
new_reason = (
601-
f"System Message: New Account. Required to wait for {delta}."
602-
)
578+
new_reason = f"System Message: New Account. Required to wait for {delta}."
603579
self.blocked_users[str(message.author.id)] = new_reason
604580
changed = True
605581

606582
if reason.startswith("System Message: New Account.") or changed:
607583
await message.channel.send(
608584
embed=discord.Embed(
609585
title="Message not sent!",
610-
description=f"Your must wait for {delta} "
611-
f"before you can contact me.",
586+
description=f"Your must wait for {delta} before you can contact me.",
612587
color=self.error_color,
613588
)
614589
)
@@ -621,18 +596,15 @@ async def _process_blocked(
621596
logger.debug("Blocked due to guild age, user %s.", message.author.name)
622597

623598
if str(message.author.id) not in self.blocked_users:
624-
new_reason = (
625-
f"System Message: Recently Joined. Required to wait for {delta}."
626-
)
599+
new_reason = f"System Message: Recently Joined. Required to wait for {delta}."
627600
self.blocked_users[str(message.author.id)] = new_reason
628601
changed = True
629602

630603
if reason.startswith("System Message: Recently Joined.") or changed:
631604
await message.channel.send(
632605
embed=discord.Embed(
633606
title="Message not sent!",
634-
description=f"Your must wait for {delta} "
635-
f"before you can contact me.",
607+
description=f"Your must wait for {delta} before you can contact me.",
636608
color=self.error_color,
637609
)
638610
)
@@ -643,9 +615,7 @@ async def _process_blocked(
643615
):
644616
# Met the age limit already, otherwise it would've been caught by the previous if's
645617
reaction = sent_emoji
646-
logger.debug(
647-
"No longer internally blocked, user %s.", message.author.name
648-
)
618+
logger.debug("No longer internally blocked, user %s.", message.author.name)
649619
self.blocked_users.pop(str(message.author.id))
650620
else:
651621
reaction = blocked_emoji
@@ -661,9 +631,7 @@ async def _process_blocked(
661631
)
662632

663633
if end_time is not None:
664-
after = (
665-
datetime.fromisoformat(end_time.group(1)) - now
666-
).total_seconds()
634+
after = (datetime.fromisoformat(end_time.group(1)) - now).total_seconds()
667635
if after <= 0:
668636
# No longer blocked
669637
reaction = sent_emoji
@@ -701,12 +669,10 @@ async def process_dm_modmail(self, message: discord.Message) -> None:
701669
description=self.config["disabled_new_thread_response"],
702670
)
703671
embed.set_footer(
704-
text=self.config["disabled_new_thread_footer"],
705-
icon_url=self.guild.icon_url,
672+
text=self.config["disabled_new_thread_footer"], icon_url=self.guild.icon_url
706673
)
707674
logger.info(
708-
"A new thread was blocked from %s due to disabled Modmail.",
709-
message.author,
675+
"A new thread was blocked from %s due to disabled Modmail.", message.author
710676
)
711677
_, blocked_emoji = await self.retrieve_emoji()
712678
await self.add_reaction(message, blocked_emoji)
@@ -724,8 +690,7 @@ async def process_dm_modmail(self, message: discord.Message) -> None:
724690
icon_url=self.guild.icon_url,
725691
)
726692
logger.info(
727-
"A message was blocked from %s due to disabled Modmail.",
728-
message.author,
693+
"A message was blocked from %s due to disabled Modmail.", message.author
729694
)
730695
_, blocked_emoji = await self.retrieve_emoji()
731696
await self.add_reaction(message, blocked_emoji)
@@ -866,9 +831,7 @@ async def process_commands(self, message):
866831
for ctx in ctxs:
867832
if ctx.command:
868833
if not any(
869-
1
870-
for check in ctx.command.checks
871-
if hasattr(check, "permission_level")
834+
1 for check in ctx.command.checks if hasattr(check, "permission_level")
872835
):
873836
logger.debug(
874837
"Command %s has no permissions check, adding invalid level.",
@@ -1064,9 +1027,7 @@ async def on_command_error(self, context, exception):
10641027
[c.__name__ for c in exception.converters]
10651028
)
10661029
await context.trigger_typing()
1067-
await context.send(
1068-
embed=discord.Embed(color=self.error_color, description=msg)
1069-
)
1030+
await context.send(embed=discord.Embed(color=self.error_color, description=msg))
10701031

10711032
elif isinstance(exception, commands.BadArgument):
10721033
await context.trigger_typing()
@@ -1082,9 +1043,7 @@ async def on_command_error(self, context, exception):
10821043
if not await check(context):
10831044
if hasattr(check, "fail_msg"):
10841045
await context.send(
1085-
embed=discord.Embed(
1086-
color=self.error_color, description=check.fail_msg
1087-
)
1046+
embed=discord.Embed(color=self.error_color, description=check.fail_msg)
10881047
)
10891048
if hasattr(check, "permission_level"):
10901049
corrected_permission_level = self.command_perm(

0 commit comments

Comments
 (0)