Skip to content

Commit ff1324c

Browse files
committed
Update sidebar
1 parent 38efe18 commit ff1324c

File tree

6 files changed

+23
-246
lines changed

6 files changed

+23
-246
lines changed

src/_common/AppSidebar/AppSidebar.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from 'react'
2+
import PropTypes from 'prop-types'
23
import { makeStyles } from '@material-ui/core/styles'
34

45
import { Link } from 'react-router-dom'
@@ -8,7 +9,7 @@ import Logo from '_common/BaseLogo/BaseLogo'
89
import SidebarNav from './AppSidebarNav'
910

1011
const Sidebar = props => {
11-
const { isDesktop, isSidebarCollapsedDesktop } = props
12+
const { isCollapsed } = props
1213

1314
const classes = useStyles(props)
1415

@@ -29,11 +30,19 @@ const Sidebar = props => {
2930
</Typography>
3031
</Link>
3132
</div>
32-
<SidebarNav isCollapsed={isDesktop && isSidebarCollapsedDesktop} />
33+
<SidebarNav isCollapsed={isCollapsed} />
3334
</aside>
3435
)
3536
}
3637

38+
Sidebar.defaultProps = {
39+
isCollapsed: false,
40+
}
41+
42+
Sidebar.propTypes = {
43+
isCollapsed: PropTypes.bool,
44+
}
45+
3746
const useStyles = makeStyles(theme => ({
3847
sidebar: {
3948
position: 'absolute',

src/_common/AppSidebar/AppSidebar.stories.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Application sidebar component.
3737
width: theme.sidebar.width,
3838
height: 1100
3939
}}>
40-
<AppSidebar collapsed={true} />
40+
<AppSidebar isCollapsed={true} />
4141
</div>
4242
)
4343
}}

src/_layouts/DashboardLayout/DashboardLayout.js

Lines changed: 11 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,10 @@ import AppFooter from '../../_common/AppFooter'
1212
import AppSidebar from '../../_common/AppSidebar'
1313

1414
const DashboardLayout = (
15-
{
16-
header,
17-
footer,
18-
sidebar,
19-
isSidebarOpenMobileInitial,
20-
isSidebarOpenDesktopInitial,
21-
isSidebarCollapsedInitial,
22-
children,
23-
} = {
15+
{ header, footer, sidebar, children } = {
2416
header: AppHeader,
2517
footer: AppFooter,
2618
sidebar: AppSidebar,
27-
isSidebarOpenMobileInitial: false,
28-
isSidebarOpenDesktopInitial: true,
29-
isSidebarCollapsedInitial: false,
3019
},
3120
) => {
3221
const refHeaderContainer = useRef(null)
@@ -38,13 +27,9 @@ const DashboardLayout = (
3827
const isDesktop = useMediaQuery(theme.breakpoints.up('md'))
3928
const isMobile = !isDesktop
4029

41-
const [isSidebarOpenMobile, setIsSidebarOpenMobile] = useState(
42-
isSidebarOpenMobileInitial,
43-
)
44-
const [isSidebarOpenDesktop, setIsSidebarOpenDesktop] = useState(
45-
isSidebarOpenDesktopInitial,
46-
)
47-
const [isSidebarCollapsed, setIsSidebarCollapsed] = useState(isSidebarCollapsedInitial)
30+
const [isSidebarOpenMobile, setIsSidebarOpenMobile] = useState(false)
31+
const [isSidebarOpenDesktop, setIsSidebarOpenDesktop] = useState(true)
32+
const [isSidebarCollapsed, setIsSidebarCollapsed] = useState(false)
4833

4934
const headerSize = useComponentSize(refHeaderContainer)
5035
// const sidebarSize = useComponentSize(refSidebarContainer)
@@ -114,13 +99,7 @@ const DashboardLayout = (
11499
keepMounted: true, // Better open performance on mobile.
115100
}}
116101
>
117-
{SidebarComponent && <SidebarComponent />}
118-
{/* <Sidebar
119-
isDesktop={isDesktop}
120-
isMobile={isMobile}
121-
isSidebarCollapsedDesktop={isSidebarCollapsedDesktop}
122-
isSidebarOpenMobile={isSidebarOpenMobile}
123-
/> */}
102+
{SidebarComponent && <SidebarComponent isCollapsed={isSidebarCollapsed} />}
124103
</Drawer>
125104
</Hidden>
126105
<Hidden smDown implementation="css">
@@ -131,13 +110,6 @@ const DashboardLayout = (
131110
variant="permanent"
132111
>
133112
{SidebarComponent && <SidebarComponent />}
134-
{/* {sidebar} */}
135-
{/* <Sidebar
136-
isDesktop={isDesktop}
137-
isMobile={isMobile}
138-
isSidebarCollapsedDesktop={isSidebarCollapsedDesktop}
139-
isSidebarOpenMobile={isSidebarOpenMobile}
140-
/> */}
141113
</Drawer>
142114
</Hidden>
143115
</div>
@@ -156,13 +128,16 @@ const DashboardLayout = (
156128
)
157129
}
158130

131+
DashboardLayout.defaultProps = {
132+
header: AppHeader,
133+
sidebar: AppSidebar,
134+
footer: AppFooter,
135+
}
136+
159137
DashboardLayout.propTypes = {
160138
header: PropTypes.elementType,
161139
sidebar: PropTypes.elementType,
162140
footer: PropTypes.elementType,
163-
isSidebarOpenMobileInitial: PropTypes.bool,
164-
isSidebarOpenDesktopInitial: PropTypes.bool,
165-
isSidebarCollapsedInitial: PropTypes.bool,
166141
}
167142

168143
const useStyles = makeStyles(theme => ({

src/_layouts/DashboardLayout2/DashboardLayout.js

Lines changed: 0 additions & 187 deletions
This file was deleted.

src/_layouts/DashboardLayout2/DashboardLayout.stories.mdx

Lines changed: 0 additions & 19 deletions
This file was deleted.

src/_layouts/DashboardLayout2/index.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)