Skip to content

Commit aa50428

Browse files
author
Katie.Ransom
committed
Switch from seleniarm to selenium for arm64 architecture
The seleniarm fork has now been merged into the main selenium project.
1 parent fc6b411 commit aa50428

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

runner/main/modules/docker-selenium/docker-selenium.sh

+5-9
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ function docker-selenium_env() {
3232
SELENIUMURL_9
3333
SELENIUMURL_10
3434

35-
TRY_SELENIARM # Only for testing purposes, decide if we want to try arm64/aarch64 images.
3635
USE_SELVERSION
3736
)
3837
echo "${env[@]}"
@@ -106,16 +105,13 @@ function docker-selenium_setup() {
106105
fi
107106

108107
# Only for testing purposes, we are going to introduce basic support for arm64 architecture.
109-
# Many of the docker images already are multi-arch, but not the selenium ones, that are using
110-
# a different repository for arm64. Let's use them here.
111108
# Important note: While we are still running Selenium 3, the arm64 images are using Selenium 4,
112109
# so they could come with new problems or incompatibilities.
113-
# As said, this is only for testing purposes, we are not going to support arm64 officially yet.
114-
# TODO: After testing, consider if we can make this the default for arm64, deleting this conf.
115-
# and using the seleniarm images when `uname -m` is arm64 or aarch64.
116-
if [[ -n ${TRY_SELENIARM} ]]; then
117-
chromeimage="seleniarm/standalone-chromium:latest"
118-
firefoximage="sseleniarm/standalone-firefox:latest"
110+
local architecture=
111+
architecture=$(uname -m)
112+
if [[ $architecture == "arm64" ]] || [[ $architecture == "aarch64" ]]; then
113+
chromeimage="selenium/standalone-chromium:latest"
114+
firefoximage="selenium/standalone-firefox:latest"
119115
fi
120116

121117
# And these are the final images and options we will use.

0 commit comments

Comments
 (0)