tested if the drivers unnecesarily opened connections

Author: transistive

src/Common/DriverSetupManager.php

@@ -11,7 +11,6 @@
 
 namespace Laudis\Neo4j\Common;
 
-use Laudis\Neo4j\Databags\SessionConfiguration;
 use function array_key_exists;
 use function array_key_first;
 use function array_reduce;
@@ -22,6 +21,7 @@
 use Laudis\Neo4j\Contracts\FormatterInterface;
 use Laudis\Neo4j\Databags\DriverConfiguration;
 use Laudis\Neo4j\Databags\DriverSetup;
+use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\DriverFactory;
 use const PHP_INT_MIN;
 use RuntimeException;

src/Http/HttpDriver.php

@@ -128,6 +128,7 @@ public function createSession(?SessionConfiguration $config = null): SessionInte
     public function verifyConnectivity(?SessionConfiguration $config = null): bool
     {
         $config ??= SessionConfiguration::default();
+
         return $this->getHttpConnectionPool($this->tsxUrl($config))
                     ->canConnect($this->uri, $this->auth);
     }

tests/Integration/ClientIntegrationTest.php

@@ -17,6 +17,8 @@
 use InvalidArgumentException;
 use Laudis\Neo4j\Authentication\Authenticate;
 use Laudis\Neo4j\Basic\Driver;
+use Laudis\Neo4j\Bolt\BoltDriver;
+use Laudis\Neo4j\Bolt\ConnectionPool;
 use Laudis\Neo4j\ClientBuilder;
 use Laudis\Neo4j\Common\Uri;
 use Laudis\Neo4j\Contracts\FormatterInterface;
@@ -27,10 +29,11 @@
 use Laudis\Neo4j\Formatter\OGMFormatter;
 use Laudis\Neo4j\Types\CypherList;
 use Laudis\Neo4j\Types\CypherMap;
+use ReflectionClass;
 use function str_starts_with;
 
 /**
- * @psalm-import-type OGMTypes from \Laudis\Neo4j\Formatter\OGMFormatter
+ * @psalm-import-type OGMTypes from OGMFormatter
  *
  * @extends EnvironmentAwareIntegrationTest<CypherList<CypherMap<OGMTypes>>>
  */
@@ -355,4 +358,45 @@ public function fetchSize(string $connection, int $fetchSize): void
 
         $this->assertCount($nodesAmount, $uniqueUserIds);
     }
+
+    public function testRedundantAcquire(): void
+    {
+        $connections = self::buildConnections();
+
+        $builder = ClientBuilder::create();
+        foreach ($connections as $i => $connection) {
+            $uri = Uri::create($connection);
+            $alias = $uri->getScheme().'_'.$i;
+            $builder = $builder->withDriver($alias, $connection);
+        }
+
+        $client = $builder->withFormatter(ClientIntegrationTest::formatter())
+            ->withDefaultSessionConfiguration(SessionConfiguration::default()->withDatabase('neo4j'))
+            ->build();
+
+        foreach ($connections as $i => $connection) {
+            $uri = Uri::create($connection);
+            $alias = $uri->getScheme().'_'.$i;
+            $client->run('MATCH (x) RETURN x', [], $alias);
+
+            $driver = $client->getDriver($alias);
+
+            // We make sure there is no redundant acquire by testing the amount of open connections.
+            // These may never exceed 1 in this simple case.
+            if ($driver instanceof BoltDriver) {
+                $reflection = new ReflectionClass($driver);
+
+                $poolProp = $reflection->getProperty('pool');
+                /** @var ConnectionPool $pool */
+                $pool = $poolProp->getValue($driver);
+
+                $reflection = new ReflectionClass($pool);
+                $connectionProp = $reflection->getProperty('activeConnections');
+                /** @var array $activeConnections */
+                $activeConnections = $connectionProp->getValue($pool);
+
+                $this->assertCount(1, $activeConnections);
+            }
+        }
+    }
 }