Skip to content

unify return values for Destroy functions #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lplewa opened this issue Mar 21, 2025 · 0 comments · May be fixed by #1356
Open

unify return values for Destroy functions #1217

lplewa opened this issue Mar 21, 2025 · 0 comments · May be fixed by #1356
Labels
1.0 API readiness Things to be improved in API before 1.0 stable release bug Something isn't working

Comments

@lplewa
Copy link
Contributor

lplewa commented Mar 21, 2025

Some umf destroy functions returns void: e.g.umfMemoryProviderDestroy, umfDisjointPoolSharedLimitsDestroy, others return umf_result e.g. umfDisjointPoolParamsDestroy

we should decide a one approach, to return value of the destruction functions, and unify it.
@lplewa lplewa added the bug Something isn't working label Mar 21, 2025
@lplewa lplewa changed the title unifiy return values for Destroy fucntions unifiy return values for Destroy functions Mar 25, 2025
@lplewa lplewa added the 1.0 API readiness Things to be improved in API before 1.0 stable release label Apr 8, 2025
lplewa added a commit to lplewa/unified-memory-framework that referenced this issue Jun 5, 2025
@lplewa
unify return values for destroy functions
7e513bc 
fixes: oneapi-src#1217
@lplewa lplewa changed the title unifiy return values for Destroy functions unify return values for Destroy functions Jun 5, 2025
@lplewa lplewa linked a pull request Jun 5, 2025 that will close this issue
Open
11 tasks
lplewa added a commit to lplewa/unified-memory-framework that referenced this issue Jun 5, 2025
@lplewa
unify return values for destroy functions
04345f0 
fixes: oneapi-src#1217
lplewa added a commit to lplewa/unified-memory-framework that referenced this issue Jun 5, 2025
@lplewa
unify return values for destroy functions
d772c99 
fixes: oneapi-src#1217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 API readiness Things to be improved in API before 1.0 stable release bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unify return values for destroy functions lplewa/unified-memory-framework
1 participant
@lplewa