Fully qualified namespace not checked in note visitors - #59

Author: sandrokeil

src/NodeVisitor/ClassExtends.php

@@ -57,7 +57,9 @@ public function afterTraverse(array $nodes): ?array
 
     private function checkExtendsExists(Stmt\Class_ $node): bool
     {
-        $exists = $this->extends === (string) $node->extends;
+        $exists = $this->extends === ($node->extends instanceof Name\FullyQualified
+                ? '\\' . $node->extends->toString()
+                : (string) $node->extends);
 
         if (false === $exists && null !== $node->extends) {
             throw new LogicException(\sprintf(

src/NodeVisitor/ClassImplements.php

@@ -11,6 +11,7 @@
 namespace OpenCodeModeling\CodeAst\NodeVisitor;
 
 use PhpParser\Node\Name;
+use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Namespace_;
 use PhpParser\NodeVisitorAbstract;
@@ -74,7 +75,9 @@ private function filterImplements(array $nodes): array
                     if ($stmt instanceof Stmt\Class_) {
                         foreach ($stmt->implements as $implementName) {
                             $implements = \array_filter($implements, static function (string $implement) use ($implementName) {
-                                return $implement !== (string) $implementName;
+                                return $implement !== ($implementName instanceof FullyQualified
+                                    ? '\\' . $implementName->toString()
+                                    : (string) $implementName);
                             });
                         }
                     }

src/NodeVisitor/ClassUseTrait.php

@@ -73,7 +73,9 @@ private function filterTraits(array $nodes): array
                                 foreach ($classStmt->traits as $trait) {
                                     $useTraits = \array_filter($useTraits,
                                         static function (string $implement) use ($trait) {
-                                            return $implement !== (string) $trait;
+                                            return $implement !== ($trait instanceof Name\FullyQualified
+                                                ? '\\' . $trait->toString()
+                                                : (string) $trait);
                                         });
                                 }
                             }

tests/Builder/ClassBuilderTest.php

@@ -76,6 +76,7 @@ final class TestClass extends BaseClass implements \Iterator, Bar
 EOF;
 
         $this->assertSame($expected, $this->printer->prettyPrintFile($nodeTraverser->traverse($ast)));
+        $this->assertSame($expected, $this->printer->prettyPrintFile($nodeTraverser->traverse($this->parser->parse($expected))));
     }
 
     /**

tests/NodeVisitor/ClassExtendsTest.php

@@ -170,6 +170,38 @@ class TestClass extends MyBaseClass
         $this->assertSame($expected, $this->printer->prettyPrintFile($nodeTraverser->traverse($ast)));
     }
 
+    /**
+     * @test
+     */
+    public function it_checks_class_extends_with_fully_qualified_namespace_for_existing_file(): void
+    {
+        $code = <<<EOF
+<?php
+
+namespace My\Awesome\Service;
+
+class TestClass extends \MyBaseClass {}
+EOF;
+
+        $ast = $this->parser->parse($code);
+
+        $nodeTraverser = new NodeTraverser();
+        $nodeTraverser->addVisitor(new ClassFile(new ClassGenerator('TestClass')));
+        $nodeTraverser->addVisitor(new ClassExtends('\\MyBaseClass'));
+
+        $expected = <<<EOF
+<?php
+
+namespace My\Awesome\Service;
+
+class TestClass extends \MyBaseClass
+{
+}
+EOF;
+
+        $this->assertSame($expected, $this->printer->prettyPrintFile($nodeTraverser->traverse($ast)));
+    }
+
     /**
      * @test
      */

tests/NodeVisitor/ClassUseTraitTest.php

@@ -43,7 +43,7 @@ public function it_add_namespace_imports_in_correct_order(): void
         $ast = $this->parser->parse($this->classCode());
 
         $nodeTraverser = new NodeTraverser();
-        $nodeTraverser->addVisitor(new ClassUseTrait('MyService\Foo', 'MyService\Bar'));
+        $nodeTraverser->addVisitor(new ClassUseTrait('\MyService\Foo', 'MyService\Bar', 'MyService\FooBar'));
 
         $this->assertSame($this->expectedClassCode(), $this->printer->prettyPrintFile($nodeTraverser->traverse($ast)));
     }
@@ -59,7 +59,8 @@ private function classCode(): string
 
         class TestClass
         {
-            use MyService\Foo;
+            use \MyService\Foo;
+            use MyService\FooBar;
 
             public function testMethod()
             {
@@ -79,7 +80,8 @@ private function expectedClassCode(): string
         class TestClass
         {
             use MyService\Bar;
-            use MyService\Foo;
+            use \MyService\Foo;
+            use MyService\FooBar;
             public function testMethod()
             {
             }