refactor to use morgan for server logs

Author: Rahman Malik

index.js

@@ -2,19 +2,14 @@ const { createSecureServer } = require("http2");
 const { readFileSync } = require("fs");
 const { join } = require("path");
 const Koa = require("koa");
-const logger = require("koa-logger");
+const morgan = require("koa-morgan");
 const Router = require("koa-router");
 const rotatingFileStream = require("rotating-file-stream");
 
 const PORT = process.env.PORT || 8443;
 
-const accessLogStream = rotatingFileStream(
-	`access.log`,
-	{ 
-		interval: `1d`, //rotate daily
-		path: join(__dirname, `log`)
-	}
-);
+const accessLogStream = getLogStream(`access.log`);
+const errorLogStream = getLogStream(`error.log`);
 
 const serverOptions = {
 	key: readFileSync(`${__dirname}/ssl/selfsigned.key`),
@@ -25,30 +20,37 @@ const app = new Koa();
 const router = new Router();
 
 router.get("/", (ctx, next, ...args) => {
-	console.log("#get /");
 	// ctx.router available
 	ctx.body = "hellooo";
 });
 
 app
-	.use(logger({
-		transporter: (str, args) => {
-			if (args.status < 400) {
-				process.stdout.write(str);
-			} else {
-				process.stderr.write(str);
-			}
-			process.stdout.write(`\n`);
-			
-			accessLogStream.write(str);
-			accessLogStream.write(`\n`);
-		}
+	.use(morgan(`dev`, {
+		skip: (req, res) => res.statusCode < 400
+	}))
+	.use(morgan(`common`, {
+		stream: accessLogStream
+	}))
+	.use(morgan(`combined`, {
+		stream: errorLogStream,
+		skip: (req, res) => res.statusCode < 400
 	}))
 	.use(router.routes())
 	.use(router.allowedMethods());
 
+console.info(`Starting server @${PORT}`);
+
 createSecureServer(serverOptions, app.callback())
 	.listen(PORT);
 
 
+function getLogStream (outputFilename) {
+	return rotatingFileStream(
+		outputFilename,
+		{ 
+			interval: `1d`, //rotate daily
+			path: join(__dirname, `log`)
+		}
+	);	
+}
 

package-lock.json

@@ -22,7 +22,7 @@
   "homepage": "https://github.com/or9/daily-coding-challenge-server#readme",
   "dependencies": {
     "koa": "^2.7.0",
-    "koa-logger": "^3.2.0",
+    "koa-morgan": "^1.0.1",
     "koa-router": "^7.4.0",
     "rotating-file-stream": "^1.4.1"
   },