Skip to content

Commit 5c381ff

Browse files
authored
Merge pull request #1 from pgasior/fix_terraform
Fix terraform
2 parents 23be350 + 09804e5 commit 5c381ff

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

iam.tf

-8
Original file line numberDiff line numberDiff line change
@@ -181,14 +181,6 @@ data "aws_iam_policy_document" "dynamodb" {
181181
resources = [
182182
module.metaflow-step-functions.metaflow_step_functions_dynamodb_table_arn
183183
]
184-
185-
condition {
186-
test = "StringEquals"
187-
values = [
188-
"sagemaker.amazonaws.com"
189-
]
190-
variable = "iam:PassedToService"
191-
}
192184
}
193185
}
194186

main.tf

-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ module "metaflow-ui" {
5353
s3_bucket_arn = module.metaflow-datastore.s3_bucket_arn
5454
subnet1_id = var.subnet1_id
5555
subnet2_id = var.subnet2_id
56-
vpc_cidr_block = var.vpc_cidr_block
5756

5857
METAFLOW_DATASTORE_SYSROOT_S3 = module.metaflow-datastore.METAFLOW_DATASTORE_SYSROOT_S3
5958
certificate_arn = var.ui_certificate_arn

modules/ui/ec2.tf

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ resource "aws_lb" "this" {
8686
}
8787

8888
resource "aws_lb_target_group" "ui_backend" {
89-
name = "${var.resource_prefix}ui-backend${var.resource_suffix}"
89+
name = format("%.32s", "${var.resource_prefix}ui-backend${var.resource_suffix}")
9090
port = 8083
9191
protocol = "HTTP"
9292
target_type = "ip"
@@ -105,7 +105,7 @@ resource "aws_lb_target_group" "ui_backend" {
105105
}
106106

107107
resource "aws_lb_target_group" "ui_static" {
108-
name = "${var.resource_prefix}ui-static${var.resource_suffix}"
108+
name = format("%.32s", "${var.resource_prefix}ui-static${var.resource_suffix}")
109109
port = 3000
110110
protocol = "HTTP"
111111
target_type = "ip"

modules/ui/ecs_ui_backend.tf

+5
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ resource "aws_ecs_task_definition" "ui_backend" {
2424
"awslogs-stream-prefix" : "ui_backend"
2525
}
2626
}
27+
command = [
28+
"/opt/latest/bin/python3",
29+
"-m",
30+
"services.ui_backend_service.ui_server"
31+
]
2732
}
2833
])
2934

0 commit comments

Comments
 (0)