allow to force destroy s3 bucket (#14)

Author: oavdeev

modules/datastore/README.md

@@ -22,6 +22,7 @@ To read more, see [the Metaflow docs](https://docs.metaflow.org/metaflow-on-aws/
 | <a name="input_db_instance_type"></a> [db\_instance\_type](#input\_db\_instance\_type) | RDS instance type to launch for PostgresQL database. | `string` | `"db.t2.small"` | no |
 | <a name="input_db_name"></a> [db\_name](#input\_db\_name) | Name of PostgresQL database for Metaflow service. | `string` | `"metaflow"` | no |
 | <a name="input_db_username"></a> [db\_username](#input\_db\_username) | PostgresQL username; defaults to 'metaflow' | `string` | `"metaflow"` | no |
+| <a name="input_force_destroy_s3_bucket"></a> [force\_destroy\_s3\_bucket](#input\_force\_destroy\_s3\_bucket) | Empty S3 bucket before destroying via terraform destroy | `bool` | `false` | no |
 | <a name="input_metadata_service_security_group_id"></a> [metadata\_service\_security\_group\_id](#input\_metadata\_service\_security\_group\_id) | The security group ID used by the MetaData service. We'll grant this access to our DB. | `string` | n/a | yes |
 | <a name="input_metaflow_vpc_id"></a> [metaflow\_vpc\_id](#input\_metaflow\_vpc\_id) | ID of the Metaflow VPC this SageMaker notebook instance is to be deployed in | `string` | n/a | yes |
 | <a name="input_resource_prefix"></a> [resource\_prefix](#input\_resource\_prefix) | Prefix given to all AWS resources to differentiate between applications | `string` | n/a | yes |

modules/datastore/s3.tf

@@ -1,6 +1,7 @@
 resource "aws_s3_bucket" "this" {
   bucket = local.s3_bucket_name
   acl    = "private"
+  force_destroy = var.force_destroy_s3_bucket
   server_side_encryption_configuration {
     rule {
       apply_server_side_encryption_by_default {

modules/datastore/variables.tf

@@ -10,6 +10,11 @@ variable "db_name" {
   default     = "metaflow"
 }
 
+variable "force_destroy_s3_bucket" {
+  type = bool
+  description = "Empty S3 bucket before destroying via terraform destroy"
+  default = false
+}
 variable "db_username" {
   type        = string
   description = "PostgresQL username; defaults to 'metaflow'"