Skip to content

Commit 7705db1

Browse files
Excavator: Migrate to the logsafe SafeLogger API
1 parent 916c91a commit 7705db1

File tree

11 files changed

+31
-30
lines changed

11 files changed

+31
-30
lines changed

docker-compose-rule-core/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,5 @@ dependencies {
2828
testImplementation 'com.github.tomakehurst:wiremock'
2929

3030
integrationTestCompile project.sourceSets.test.output
31+
implementation 'com.palantir.safe-logging:logger'
3132
}

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/DockerComposeManager.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@
5151
import com.palantir.docker.compose.logging.LogDirectory;
5252
import com.palantir.docker.compose.report.TestDescription;
5353
import com.palantir.docker.compose.reporting.RunRecorder;
54+
import com.palantir.logsafe.logger.SafeLogger;
55+
import com.palantir.logsafe.logger.SafeLoggerFactory;
5456
import java.io.IOException;
5557
import java.util.List;
5658
import java.util.concurrent.ExecutionException;
@@ -61,14 +63,12 @@
6163
import org.immutables.value.Value;
6264
import org.joda.time.Duration;
6365
import org.joda.time.ReadableDuration;
64-
import org.slf4j.Logger;
65-
import org.slf4j.LoggerFactory;
6666

6767
@Value.Immutable
6868
@CustomImmutablesStyle
6969
@SuppressWarnings("DesignForExtension")
7070
public abstract class DockerComposeManager {
71-
private static final Logger log = LoggerFactory.getLogger(DockerComposeManager.class);
71+
private static final SafeLogger log = SafeLoggerFactory.get(DockerComposeManager.class);
7272

7373
public static final Duration DEFAULT_TIMEOUT = Duration.standardMinutes(2);
7474
public static final int DEFAULT_RETRY_ATTEMPTS = 2;

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/connection/waiting/ClusterWait.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
package com.palantir.docker.compose.connection.waiting;
1717

1818
import com.palantir.docker.compose.connection.Cluster;
19+
import com.palantir.logsafe.logger.SafeLogger;
20+
import com.palantir.logsafe.logger.SafeLoggerFactory;
1921
import java.util.Optional;
2022
import java.util.concurrent.Callable;
2123
import java.util.concurrent.ThreadLocalRandom;
@@ -24,11 +26,9 @@
2426
import org.awaitility.core.ConditionTimeoutException;
2527
import org.joda.time.Duration;
2628
import org.joda.time.ReadableDuration;
27-
import org.slf4j.Logger;
28-
import org.slf4j.LoggerFactory;
2929

3030
public final class ClusterWait {
31-
private static final Logger log = LoggerFactory.getLogger(ClusterWait.class);
31+
private static final SafeLogger log = SafeLoggerFactory.get(ClusterWait.class);
3232
private final ClusterHealthCheck clusterHealthCheck;
3333
private final Duration timeout;
3434

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/execution/DockerExecutable.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,16 @@
1616
package com.palantir.docker.compose.execution;
1717

1818
import com.google.common.collect.ImmutableList;
19+
import com.palantir.logsafe.logger.SafeLogger;
20+
import com.palantir.logsafe.logger.SafeLoggerFactory;
1921
import java.io.IOException;
2022
import java.util.List;
2123
import org.immutables.value.Value;
22-
import org.slf4j.Logger;
23-
import org.slf4j.LoggerFactory;
2424

2525
@Value.Immutable
2626
@SuppressWarnings("DesignForExtension")
2727
public abstract class DockerExecutable implements Executable {
28-
private static final Logger log = LoggerFactory.getLogger(DockerExecutable.class);
28+
private static final SafeLogger log = SafeLoggerFactory.get(DockerExecutable.class);
2929

3030
private static final DockerCommandLocations DOCKER_LOCATIONS =
3131
new DockerCommandLocations(System.getenv("DOCKER_LOCATION"), "/usr/local/bin/docker", "/usr/bin/docker");

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/execution/GracefulShutdownStrategy.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@
1717
package com.palantir.docker.compose.execution;
1818

1919
import com.palantir.docker.compose.configuration.ShutdownStrategy;
20+
import com.palantir.logsafe.logger.SafeLogger;
21+
import com.palantir.logsafe.logger.SafeLoggerFactory;
2022
import java.io.IOException;
21-
import org.slf4j.Logger;
22-
import org.slf4j.LoggerFactory;
2323

2424
/**
2525
* Send SIGTERM to containers first, allowing them up to 10 seconds to
2626
* terminate before killing and rm-ing them.
2727
*/
2828
public final class GracefulShutdownStrategy implements ShutdownStrategy {
2929

30-
private static final Logger log = LoggerFactory.getLogger(GracefulShutdownStrategy.class);
30+
private static final SafeLogger log = SafeLoggerFactory.get(GracefulShutdownStrategy.class);
3131

3232
@Override
3333
public void stop(DockerCompose dockerCompose) throws IOException, InterruptedException {

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/execution/KillDownShutdownStrategy.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
package com.palantir.docker.compose.execution;
1818

1919
import com.palantir.docker.compose.configuration.ShutdownStrategy;
20+
import com.palantir.logsafe.logger.SafeLogger;
21+
import com.palantir.logsafe.logger.SafeLoggerFactory;
2022
import java.io.IOException;
21-
import org.slf4j.Logger;
22-
import org.slf4j.LoggerFactory;
2323

2424
/**
2525
* Shuts down fast but cleanly by issuing a kill (fast shutdown) followed by a down (thorough cleanup)
@@ -30,7 +30,7 @@
3030
*/
3131
public final class KillDownShutdownStrategy implements ShutdownStrategy {
3232

33-
private static final Logger log = LoggerFactory.getLogger(KillDownShutdownStrategy.class);
33+
private static final SafeLogger log = SafeLoggerFactory.get(KillDownShutdownStrategy.class);
3434

3535
@Override
3636
public void stop(DockerCompose dockerCompose) throws IOException, InterruptedException {

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/execution/SkipShutdownStrategy.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
package com.palantir.docker.compose.execution;
1818

1919
import com.palantir.docker.compose.configuration.ShutdownStrategy;
20-
import org.slf4j.Logger;
21-
import org.slf4j.LoggerFactory;
20+
import com.palantir.logsafe.logger.SafeLogger;
21+
import com.palantir.logsafe.logger.SafeLoggerFactory;
2222

2323
public final class SkipShutdownStrategy implements ShutdownStrategy {
2424

25-
private static final Logger log = LoggerFactory.getLogger(SkipShutdownStrategy.class);
25+
private static final SafeLogger log = SafeLoggerFactory.get(SkipShutdownStrategy.class);
2626

2727
@Override
2828
public void shutdown(DockerCompose _dockerCompose, Docker _docker) {

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/reporting/HttpJsonPoster.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
package com.palantir.docker.compose.reporting;
1818

1919
import com.google.common.io.CharStreams;
20+
import com.palantir.logsafe.logger.SafeLogger;
21+
import com.palantir.logsafe.logger.SafeLoggerFactory;
2022
import java.io.BufferedWriter;
2123
import java.io.InputStreamReader;
2224
import java.io.OutputStreamWriter;
@@ -25,11 +27,9 @@
2527
import java.net.URL;
2628
import java.nio.charset.StandardCharsets;
2729
import java.util.Optional;
28-
import org.slf4j.Logger;
29-
import org.slf4j.LoggerFactory;
3030

3131
class HttpJsonPoster {
32-
private static final Logger log = LoggerFactory.getLogger(HttpJsonPoster.class);
32+
private static final SafeLogger log = SafeLoggerFactory.get(HttpJsonPoster.class);
3333

3434
private final ReportingConfig reportingConfig;
3535

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/reporting/ReportCompiler.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
import com.palantir.docker.compose.report.Versions;
2525
import com.palantir.logsafe.SafeArg;
2626
import com.palantir.logsafe.exceptions.SafeRuntimeException;
27+
import com.palantir.logsafe.logger.SafeLogger;
28+
import com.palantir.logsafe.logger.SafeLoggerFactory;
2729
import java.io.IOException;
2830
import java.io.InputStream;
2931
import java.io.InputStreamReader;
@@ -36,11 +38,9 @@
3638
import java.util.concurrent.TimeUnit;
3739
import java.util.function.Consumer;
3840
import one.util.streamex.EntryStream;
39-
import org.slf4j.Logger;
40-
import org.slf4j.LoggerFactory;
4141

4242
final class ReportCompiler implements Reporter {
43-
private static final Logger log = LoggerFactory.getLogger(ReportCompiler.class);
43+
private static final SafeLogger log = SafeLoggerFactory.get(ReportCompiler.class);
4444

4545
private static final String REPORT_API_VERSION = "2";
4646

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/reporting/Reporter.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818

1919
import com.palantir.docker.compose.configuration.DockerComposeRuleConfig;
2020
import com.palantir.docker.compose.report.DockerComposeRun;
21-
import org.slf4j.Logger;
22-
import org.slf4j.LoggerFactory;
21+
import com.palantir.logsafe.logger.SafeLogger;
22+
import com.palantir.logsafe.logger.SafeLoggerFactory;
2323

2424
interface Reporter {
2525
void addRun(DockerComposeRun dockerComposeRun);
@@ -29,7 +29,7 @@ interface Reporter {
2929
void report();
3030

3131
final class NoOpReporter implements Reporter {
32-
private static final Logger log = LoggerFactory.getLogger(NoOpReporter.class);
32+
private static final SafeLogger log = SafeLoggerFactory.get(NoOpReporter.class);
3333

3434
public static final Reporter INSTANCE = new NoOpReporter();
3535

docker-compose-rule-core/src/main/java/com/palantir/docker/compose/reporting/RunRecorder.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020
import com.palantir.docker.compose.events.EventConsumer;
2121
import com.palantir.docker.compose.report.DockerComposeRun;
2222
import com.palantir.docker.compose.report.TestDescription;
23+
import com.palantir.logsafe.logger.SafeLogger;
24+
import com.palantir.logsafe.logger.SafeLoggerFactory;
2325
import java.time.Clock;
2426
import java.time.ZoneOffset;
2527
import java.util.concurrent.Callable;
26-
import org.slf4j.Logger;
27-
import org.slf4j.LoggerFactory;
2828

2929
public final class RunRecorder implements EventConsumer {
30-
private static final Logger log = LoggerFactory.getLogger(RunRecorder.class);
30+
private static final SafeLogger log = SafeLoggerFactory.get(RunRecorder.class);
3131

3232
private final Clock clock;
3333
private final Reporter reporter;

0 commit comments

Comments
 (0)