Skip to content

Commit e355f36

Browse files
dplewisdplewis
authored
ci: Find duplicate and slow tests (#9188)
1 parent 872b9eb commit e355f36

13 files changed

+43
-170
lines changed

‎.nvmrc

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
10.14.2
2-
1+
20.15.0

‎spec/Auth.spec.js

-29
Original file line numberDiff line numberDiff line change
@@ -141,35 +141,6 @@ describe('Auth', () => {
141141
expect(userAuth.user.id).toBe(user.id);
142142
});
143143

144-
it('should load auth without a config', async () => {
145-
const user = new Parse.User();
146-
await user.signUp({
147-
username: 'hello',
148-
password: 'password',
149-
});
150-
expect(user.getSessionToken()).not.toBeUndefined();
151-
const userAuth = await getAuthForSessionToken({
152-
sessionToken: user.getSessionToken(),
153-
});
154-
expect(userAuth.user instanceof Parse.User).toBe(true);
155-
expect(userAuth.user.id).toBe(user.id);
156-
});
157-
158-
it('should load auth with a config', async () => {
159-
const user = new Parse.User();
160-
await user.signUp({
161-
username: 'hello',
162-
password: 'password',
163-
});
164-
expect(user.getSessionToken()).not.toBeUndefined();
165-
const userAuth = await getAuthForSessionToken({
166-
sessionToken: user.getSessionToken(),
167-
config: Config.get('test'),
168-
});
169-
expect(userAuth.user instanceof Parse.User).toBe(true);
170-
expect(userAuth.user.id).toBe(user.id);
171-
});
172-
173144
describe('getRolesForUser', () => {
174145
const rolesNumber = 100;
175146

‎spec/AuthenticationAdapters.spec.js

+2-25
Original file line numberDiff line numberDiff line change
@@ -469,29 +469,6 @@ describe('AuthenticationProviders', function () {
469469
expect(providerOptions).toEqual(options.facebook);
470470
});
471471

472-
it('should throw error when Facebook request appId is wrong data type', async () => {
473-
const httpsRequest = require('../lib/Adapters/Auth/httpsRequest');
474-
spyOn(httpsRequest, 'get').and.callFake(() => {
475-
return Promise.resolve({ id: 'a' });
476-
});
477-
const options = {
478-
facebook: {
479-
appIds: 'abcd',
480-
appSecret: 'secret_sauce',
481-
},
482-
};
483-
const authData = {
484-
access_token: 'badtoken',
485-
};
486-
const { adapter, appIds, providerOptions } = authenticationLoader.loadAuthAdapter(
487-
'facebook',
488-
options
489-
);
490-
await expectAsync(adapter.validateAppId(appIds, authData, providerOptions)).toBeRejectedWith(
491-
new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'appIds must be an array.')
492-
);
493-
});
494-
495472
it('should handle Facebook appSecret for validating appIds', async () => {
496473
const httpsRequest = require('../lib/Adapters/Auth/httpsRequest');
497474
spyOn(httpsRequest, 'get').and.callFake(() => {
@@ -1652,7 +1629,7 @@ describe('apple signin auth adapter', () => {
16521629
}
16531630
});
16541631

1655-
it('(using client id as string) should throw error with with invalid jwt issuer', async () => {
1632+
it('(using client id as string) should throw error with with invalid jwt issuer with token', async () => {
16561633
const fakeClaim = {
16571634
iss: 'https://not.apple.com',
16581635
sub: 'the_user_id',
@@ -2208,7 +2185,7 @@ describe('facebook limited auth adapter', () => {
22082185
}
22092186
});
22102187

2211-
it('(using client id as string) should throw error with with invalid jwt issuer', async () => {
2188+
it('(using client id as string) with token', async () => {
22122189
const fakeClaim = {
22132190
iss: 'https://not.facebook.com',
22142191
sub: 'the_user_id',

‎spec/AuthenticationAdaptersV2.spec.js

-10
Original file line numberDiff line numberDiff line change
@@ -369,16 +369,6 @@ describe('Auth Adapter features', () => {
369369
expect(spy).toHaveBeenCalled();
370370
});
371371

372-
it('should throw if no triggers found', async () => {
373-
await reconfigureServer({ auth: { wrongAdapter } });
374-
const user = new Parse.User();
375-
await expectAsync(
376-
user.save({ authData: { wrongAdapter: { id: 'wrongAdapter' } } })
377-
).toBeRejectedWithError(
378-
'Adapter is not configured. Implement either validateAuthData or all of the following: validateSetUp, validateLogin and validateUpdate'
379-
);
380-
});
381-
382372
it('should throw if policy does not match one of default/solo/additional', async () => {
383373
const adapterWithBadPolicy = {
384374
validateAppId: () => Promise.resolve(),

‎spec/CloudCode.Validator.spec.js

+1-22
Original file line numberDiff line numberDiff line change
@@ -194,27 +194,6 @@ describe('cloud validator', () => {
194194
});
195195
});
196196

197-
it('set params on cloud functions', done => {
198-
Parse.Cloud.define(
199-
'hello',
200-
() => {
201-
return 'Hello world!';
202-
},
203-
{
204-
fields: ['a'],
205-
}
206-
);
207-
Parse.Cloud.run('hello', {})
208-
.then(() => {
209-
fail('function should have failed.');
210-
})
211-
.catch(error => {
212-
expect(error.code).toEqual(Parse.Error.VALIDATION_ERROR);
213-
expect(error.message).toEqual('Validation failed. Please specify data for a.');
214-
done();
215-
});
216-
});
217-
218197
it('allow params on cloud functions', done => {
219198
Parse.Cloud.define(
220199
'hello',
@@ -1629,7 +1608,7 @@ describe('cloud validator', () => {
16291608
}
16301609
});
16311610

1632-
it('Logs on invalid config', () => {
1611+
it('Logs on multiple invalid configs', () => {
16331612
const fields = [
16341613
{
16351614
field: 'otherKey',

‎spec/CloudCode.spec.js

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ describe('Cloud Code', () => {
4949
});
5050

5151
it('cloud code must be valid type', async () => {
52+
spyOn(console, 'error').and.callFake(() => {});
5253
await expectAsync(reconfigureServer({ cloud: true })).toBeRejectedWith(
5354
"argument 'cloud' must either be a string or a function"
5455
);

‎spec/ParseFile.spec.js

-48
Original file line numberDiff line numberDiff line change
@@ -789,59 +789,11 @@ describe('Parse.File testing', () => {
789789
headers: {
790790
'Content-Type': 'application/octet-stream',
791791
'X-Parse-Application-Id': 'test',
792-
Range: 'bytes=abc-efs',
793792
},
794793
}).catch(e => e);
795794
expect(file.headers['content-range']).toBeUndefined();
796795
});
797796

798-
it('supports bytes range if start and end undefined', async () => {
799-
const headers = {
800-
'Content-Type': 'application/octet-stream',
801-
'X-Parse-Application-Id': 'test',
802-
'X-Parse-REST-API-Key': 'rest',
803-
};
804-
const response = await request({
805-
method: 'POST',
806-
headers: headers,
807-
url: 'http://localhost:8378/1//files/file.txt ',
808-
body: repeat('argle bargle', 100),
809-
});
810-
const b = response.data;
811-
const file = await request({
812-
url: b.url,
813-
headers: {
814-
'Content-Type': 'application/octet-stream',
815-
'X-Parse-Application-Id': 'test',
816-
},
817-
}).catch(e => e);
818-
expect(file.headers['content-range']).toBeUndefined();
819-
});
820-
821-
it('supports bytes range if end is greater than size', async () => {
822-
const headers = {
823-
'Content-Type': 'application/octet-stream',
824-
'X-Parse-Application-Id': 'test',
825-
'X-Parse-REST-API-Key': 'rest',
826-
};
827-
const response = await request({
828-
method: 'POST',
829-
headers: headers,
830-
url: 'http://localhost:8378/1//files/file.txt ',
831-
body: repeat('argle bargle', 100),
832-
});
833-
const b = response.data;
834-
const file = await request({
835-
url: b.url,
836-
headers: {
837-
'Content-Type': 'application/octet-stream',
838-
'X-Parse-Application-Id': 'test',
839-
Range: 'bytes=0-2000',
840-
},
841-
}).catch(e => e);
842-
expect(file.headers['content-range']).toBe('bytes 0-1212/1212');
843-
});
844-
845797
it('supports bytes range if end is greater than size', async () => {
846798
const headers = {
847799
'Content-Type': 'application/octet-stream',

‎spec/ParseLiveQuery.spec.js

-1
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,6 @@ describe('ParseLiveQuery', function () {
382382
await obj2.save();
383383
obj2.set('foo', 'bart');
384384
await obj2.save();
385-
await sleep(2000);
386385
expect(createSpy).toHaveBeenCalledTimes(1);
387386
expect(updateSpy).toHaveBeenCalledTimes(1);
388387
});

‎spec/ParseLiveQueryServer.spec.js

-29
Original file line numberDiff line numberDiff line change
@@ -1633,35 +1633,6 @@ describe('ParseLiveQueryServer', function () {
16331633
});
16341634
});
16351635

1636-
it('matches CLP when find is restricted to userIds', done => {
1637-
const parseLiveQueryServer = new ParseLiveQueryServer({});
1638-
const acl = new Parse.ACL();
1639-
acl.setReadAccess(testUserId, true);
1640-
// Mock sessionTokenCache will return false when sessionToken is undefined
1641-
const client = {
1642-
sessionToken: 'sessionToken',
1643-
getSubscriptionInfo: jasmine.createSpy('getSubscriptionInfo').and.returnValue({
1644-
sessionToken: 'userId',
1645-
}),
1646-
};
1647-
const requestId = 0;
1648-
1649-
parseLiveQueryServer
1650-
._matchesCLP(
1651-
{
1652-
find: { userId: true },
1653-
},
1654-
{ className: 'Yolo' },
1655-
client,
1656-
requestId,
1657-
'find'
1658-
)
1659-
.then(isMatched => {
1660-
expect(isMatched).toBe(true);
1661-
done();
1662-
});
1663-
});
1664-
16651636
it('matches CLP when find is restricted to userIds', done => {
16661637
const parseLiveQueryServer = new ParseLiveQueryServer({});
16671638
const acl = new Parse.ACL();

‎spec/PostgresStorageAdapter.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ describe_only_db('postgres')('PostgresStorageAdapter', () => {
362362
await dropTable(client, tableName);
363363
});
364364

365-
it('should use index for caseInsensitive query', async () => {
365+
it('should use index for caseInsensitive query with user', async () => {
366366
await adapter.deleteAllClasses();
367367
const config = Config.get('test');
368368
config.schemaCache.clear();

‎spec/PushWorker.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ describe('PushWorker', () => {
120120
});
121121
});
122122

123-
it('transforms body appropriately', () => {
123+
it('transforms body appropriately with title locale', () => {
124124
const cleanBody = PushUtils.transformPushBodyForLocale(
125125
{
126126
data: {

‎spec/helper.js

+4
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,10 @@ afterEach(function (done) {
286286
.then(afterLogOut);
287287
});
288288

289+
afterAll(() => {
290+
global.displaySlowTests();
291+
});
292+
289293
const TestObject = Parse.Object.extend({
290294
className: 'TestObject',
291295
});

‎spec/support/CurrentSpecReporter.js

+32-2
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,45 @@
11
// Sets a global variable to the current test spec
22
// ex: global.currentSpec.description
3-
3+
const { performance } = require('perf_hooks');
44
global.currentSpec = null;
55

6+
const timerMap = {};
7+
const duplicates = [];
8+
/** The minimum execution time in seconds for a test to be considered slow. */
9+
const slowTestLimit = 2;
10+
611
class CurrentSpecReporter {
712
specStarted(spec) {
13+
if (timerMap[spec.fullName]) {
14+
console.log('Duplicate spec: ' + spec.fullName);
15+
duplicates.push(spec.fullName);
16+
}
17+
timerMap[spec.fullName] = performance.now();
818
global.currentSpec = spec;
919
}
10-
specDone() {
20+
specDone(result) {
21+
if (result.status === 'excluded') {
22+
delete timerMap[result.fullName];
23+
return;
24+
}
25+
timerMap[result.fullName] = (performance.now() - timerMap[result.fullName]) / 1000;
1126
global.currentSpec = null;
1227
}
1328
}
29+
global.displaySlowTests = function() {
30+
const times = Object.values(timerMap).sort((a,b) => b - a);
31+
if (times.length > 0) {
32+
console.log(`Slow tests with execution time >=${slowTestLimit}s:`);
33+
}
34+
times.forEach((time) => {
35+
if (time >= slowTestLimit) {
36+
console.warn(`${time.toFixed(1)}s:`, Object.keys(timerMap).find(key => timerMap[key] === time));
37+
}
38+
});
39+
console.log('\n');
40+
duplicates.forEach((spec) => {
41+
console.warn('Duplicate spec: ' + spec);
42+
});
43+
};
1444

1545
module.exports = CurrentSpecReporter;

0 commit comments

Comments
 (0)