Skip to content

Commit 69467b7

Browse files
committed
Update php-sap/common to version 2.0
* Removed any remains of typecasting.
1 parent ef10fd9 commit 69467b7

File tree

4 files changed

+14
-50
lines changed

4 files changed

+14
-50
lines changed

composer.lock

Lines changed: 14 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/AbstractRemoteFunctionCall.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,4 @@ protected function createConnectionInstance(IConfig $config)
3434
{
3535
return new SapRfcConnection($config);
3636
}
37-
38-
/**
39-
* Get the typecast of the expected return values.
40-
* @return \kbATeam\TypeCast\ITypeCast|null
41-
*/
42-
protected function getReturnTypecast()
43-
{
44-
return null;
45-
}
4637
}

tests/AbstractRemoteFunctionCallTest.php

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,4 @@ public function testCreateConnectionInstance()
4242
$connection = $rfc->createConnectionInstance($config);
4343
static::assertInstanceOf(SapRfcConnection::class, $connection);
4444
}
45-
46-
/**
47-
* Test getting an empty return typecast.
48-
*/
49-
public function testGetReturnTypecast()
50-
{
51-
$config = new SapRfcConfigA([
52-
'ashost' => 'sap.example.com',
53-
'sysnr' => '001',
54-
'client' => '002',
55-
'user' => 'username',
56-
'passwd' => 'password'
57-
]);
58-
$rfc = new RemoteFunctionCall($config);
59-
static::assertNull($rfc->getReturnTypecast());
60-
}
6145
}

tests/helper/RemoteFunctionCall.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,4 @@ public function createConnectionInstance(IConfig $config)
5050
{
5151
return parent::createConnectionInstance($config);
5252
}
53-
54-
/**
55-
* Make protected function public for testing.
56-
* Get the typecast of the expected return values.
57-
* @return \kbATeam\TypeCast\ITypeCast|null
58-
*/
59-
public function getReturnTypecast()
60-
{
61-
return parent::getReturnTypecast();
62-
}
6353
}

0 commit comments

Comments
 (0)