InsertOrUpdate does not change the primary key on update

phpfui · phpfui · commit 2e5391b7ec10 · 2023-10-19T11:01:27.000-04:00
diff --git a/src/PHPFUI/ORM/Record.php b/src/PHPFUI/ORM/Record.php
@@ -924,7 +924,11 @@ private function privateInsert(bool $updateOnDuplicate, string $ignore = '') : i
 
 		if (static::$autoIncrement && $returnValue)
 			{
-			$this->current[static::$primaryKeys[0]] = $returnValue = (int)\PHPFUI\ORM::lastInsertId(static::$primaryKeys[0]);
+			$returnValue = (int)\PHPFUI\ORM::lastInsertId(static::$primaryKeys[0]);
+			if ($returnValue)
+				{
+				$this->current[static::$primaryKeys[0]] = $returnValue;
+				}
 			}
 
 		$this->loaded = true;	// record is effectively read from the database now

Original file line number	Diff line number	Diff line change
`@@ -924,7 +924,11 @@ private function privateInsert(bool $updateOnDuplicate, string $ignore = '') : i`
`924`	`924`
`925`	`925`	`if (static::$autoIncrement && $returnValue)`
`926`	`926`	`{`
`927`		`- $this->current[static::$primaryKeys[0]] = $returnValue = (int)\PHPFUI\ORM::lastInsertId(static::$primaryKeys[0]);`
	`927`	`+ $returnValue = (int)\PHPFUI\ORM::lastInsertId(static::$primaryKeys[0]);`
	`928`	`+ if ($returnValue)`
	`929`	`+ {`
	`930`	`+ $this->current[static::$primaryKeys[0]] = $returnValue;`
	`931`	`+ }`
`928`	`932`	`}`
`929`	`933`
`930`	`934`	`$this->loaded = true; // record is effectively read from the database now`