We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi!
We have a use case where we need to only load the first N records of a file.
It's currently not supported but the change could be minimal. So in \PhpMyAdmin\ShapeFile\ShapeFile::loadRecords we would need to change
\PhpMyAdmin\ShapeFile\ShapeFile::loadRecords
$this->records[] = $record;
to
$this->records[] = $record; if (count($this->records) >= $this->maxRecords) { break; }
$maxRecords could be initialized to a large value or accept int or bool and code would be
$maxRecords
int
bool
$this->records[] = $record; if ($this->maxRecords && count($this->records) >= $this->maxRecords) { break; }
Thoughts?
The text was updated successfully, but these errors were encountered:
add a max number of records to load
9843390
fixes phpmyadmin#42
add test
9c42aa3
add a max number of records to load fixes phpmyadmin#42
523abbb
6415d24
yes, why not. I prefer to avoid counting multiple times If you add tests for it, then for me it should be okay at PR review time
Sorry, something went wrong.
No branches or pull requests
Hi!
We have a use case where we need to only load the first N records of a file.
It's currently not supported but the change could be minimal.
So in
\PhpMyAdmin\ShapeFile\ShapeFile::loadRecords
we would need to changeto
$maxRecords
could be initialized to a large value or acceptint
orbool
and code would beThoughts?
The text was updated successfully, but these errors were encountered: