-
-
Notifications
You must be signed in to change notification settings - Fork 99
Support for ARM runners #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would increase the support surface area and maintenance burden related to it. So I'm not sure I want to do this. What's the motivation here, anyway? I noticed that most unusual requests are coming from people refusing to follow the documented and supported way of using the action. |
To be able to run all our CI workflows on the cheaper ARM runners.
I don't think it's documented anywhere that this action only works on the x86/amd64 architecture? My reason for making this issue was also to let you know that ARM runners now is a thing, and due to how this action is made, it won't work on them out of the box, unlike most other actions available. |
The docker requirement might be circumvented with a dedicated venv (possibly using
This phrase implies presumptions (👎🏼). I suspect any action using a docker container, especially using custom docker images like this one, would have similar problems. And, a lot of actions use docker containers if they are not driven by JS/TS. Composite actions were introduced to bypass the limitations of docker containers' isolation (and more). |
I just migrated all our workflows to run on ARM runners, and this was the only action that wasn't compatible with them. |
Yep. Docker is only available on GNU/Linux runners. |
The action currently fails to run on the ARM runners GitHub have made available because the Docker image used for releases only is available for the
linux/amd64
architecture.Would it be possible to add support for
linux/arm64
as well, please?It looks like https://github.com/pypa/gh-action-pypi-publish/blob/HEAD/.github/workflows/build-and-push-docker-image.yml is what needs to be edited to accomplish this.
That workflow could potentially be changed to make use of some of the existing actions available for building Docker images, such as what I use here: https://github.com/Tenzer/dockerfiles/blob/main/.github/workflows/uwsgi-werkzeug-echo.yml. I don't know if that would be appreciated or not.
The text was updated successfully, but these errors were encountered: